From b49d52e78bd361d4f6442b2b8ab0354ca171fa9a Mon Sep 17 00:00:00 2001
From: The-EDev <farook@the-e-dev.com>
Date: Sun, 18 Oct 2020 01:34:58 +0300
Subject: [PATCH 1/7] Added basic multipart data structure Including methods to
 generate multipart message from request

---
 include/crow.h           |   2 +
 include/crow/multipart.h | 195 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 197 insertions(+)
 create mode 100644 include/crow/multipart.h

diff --git a/include/crow.h b/include/crow.h
index 9a0c22e11..98df4b64f 100644
--- a/include/crow.h
+++ b/include/crow.h
@@ -11,10 +11,12 @@
 #include "crow/dumb_timer_queue.h"
 #include "crow/utility.h"
 #include "crow/common.h"
+#include "crow/mime_types.h"
 #include "crow/http_request.h"
 #include "crow/websocket.h"
 #include "crow/parser.h"
 #include "crow/http_response.h"
+#include "crow/multipart.h"
 #include "crow/middleware.h"
 #include "crow/routing.h"
 #include "crow/middleware_context.h"
diff --git a/include/crow/multipart.h b/include/crow/multipart.h
new file mode 100644
index 000000000..3cc4a586b
--- /dev/null
+++ b/include/crow/multipart.h
@@ -0,0 +1,195 @@
+#pragma once
+#include <string>
+#include <vector>
+#include <sstream>
+#include "crow/http_request.h"
+#include "crow/http_response.h"
+
+namespace crow
+{
+    ///Encapsulates anything related to processing and organizing `multipart/xyz` messages
+    namespace multipart
+    {
+        const std::string dd = "--";
+        const std::string crlf = "\r\n";
+
+        ///The first part in a section, contains metadata about the part
+        struct header
+        {
+                std::pair<std::string, std::string> value; ///< The first part of the header, usually `Content-Type` or `Content-Disposition`
+                std::unordered_map<std::string, std::string> params; ///< The parameters of the header, come after the `value`
+        };
+
+        ///One part of the multipart message
+
+        ///It is usually separated from other sections by a `boundary`
+        ///
+        struct part
+        {
+            std::vector<header> headers; ///< (optional) The first part before the data, Contains information regarding the type of data and encoding
+            std::string body; ///< The actual data in the part
+        };
+
+        ///The parsed multipart request/response
+        struct message
+        {
+            ci_map headers;
+            std::string boundary; ///< The text boundary that separates different `parts`
+            std::vector<part> parts; ///< The individual parts of the message
+
+            const std::string& get_header_value(const std::string& key) const
+            {
+                return crow::get_header_value(headers, key);
+            }
+
+            ///Represent all parts as a string (**does not include message headers**)
+            const std::string dump()
+            {
+                std::stringstream str;
+                std::string delimiter = "--" + boundary;
+
+                for (uint8_t i=0 ; i<parts.size(); i++)
+                {
+                    str << delimiter << std::endl;
+                    str << dump(i);
+                }
+                str << delimiter << "--" << std::endl;
+                return str.str();
+            }
+
+            ///Represent an individual part as a string
+            const std::string dump(int part_)
+            {
+                std::stringstream str;
+                part item = parts[part_];
+                for (header item_h: item.headers)
+                {
+                    str << item_h.value.first << ": " << item_h.value.second;
+                    for (auto& it: item_h.params)
+                    {
+                        str << "; " << it.first << '=' << pad(it.second);
+                    }
+                    str << std::endl;
+                }
+                str << std::endl;
+                str << item.body << std::endl;
+                return str.str();
+            }
+
+            ///Default constructor using default values
+            message(const ci_map& headers, const std::string& boundary, const std::vector<part>& sections)
+              : headers(headers), boundary(boundary), parts(sections){}
+
+            ///Create a multipart message from a request data
+            message(const request& req)
+              : headers(req.headers),
+                boundary(get_boundary(get_header_value("Content-Type"))),
+                parts(parse_body(req.body))
+            {}
+
+          private:
+
+            std::string get_boundary(std::string header)
+            {
+                size_t found = header.find("boundary=");
+                if (found)
+                    return header.substr(found+9);
+                static std::string empty;
+                return empty;
+            }
+
+            std::vector<part> parse_body(std::string body)
+            {
+
+                  std::vector<part> sections;
+
+                  std::string delimiter = dd + boundary;
+
+                  while(body != (crlf))
+                  {
+                      size_t found = body.find(delimiter);
+                      std::string section = body.substr(0, found);
+                      //+2 is the CRLF
+                      //We don't check it and delete it so that the same delimiter can be used for
+                      //the last delimiter (--delimiter--CRLF).
+                      body.erase(0, found + delimiter.length() + 2);
+                      if (section != "")
+                      {
+                          sections.emplace_back(parse_section(section));
+                      }
+                  }
+                  return sections;
+            }
+
+            part parse_section(std::string& section)
+            {
+                struct part to_return;
+
+                size_t found = section.find(crlf+crlf);
+                std::string head_line = section.substr(0, found+2);
+                section.erase(0, found + 4);
+
+                parse_section_head(head_line, to_return);
+                to_return.body = section.substr(0, section.length()-2);
+                return to_return;
+            }
+
+            void parse_section_head(std::string& lines, part& part)
+            {
+                while (lines != "")
+                {
+                    header to_add;
+
+                    size_t found = lines.find(crlf);
+                    std::string line = lines.substr(0, found);
+                    lines.erase(0, found+2);
+                    //add the header if available
+                    if (line != "")
+                    {
+                        size_t found = line.find("; ");
+                        std::string header = line.substr(0, found);
+                        if (found != std::string::npos)
+                            line.erase(0, found+2);
+                        else
+                            line = std::string();
+
+                        size_t header_split = header.find(": ");
+
+                        to_add.value = std::pair<std::string, std::string>(header.substr(0, header_split), header.substr(header_split+2));
+                    }
+
+                    //add the parameters
+                    while (line != "")
+                    {
+                        size_t found = line.find("; ");
+                        std::string param = line.substr(0, found);
+                        if (found != std::string::npos)
+                            line.erase(0, found+2);
+                        else
+                            line = std::string();
+
+                        size_t param_split = param.find('=');
+
+                        std::string value = param.substr(param_split+1);
+
+                        to_add.params.emplace(param.substr(0, param_split), trim(value));
+                    }
+                    part.headers.emplace_back(to_add);
+                }
+            }
+
+            inline std::string trim (std::string& string, char excess = '"')
+            {
+                if (string.length() > 1 && string[0] == excess && string[string.length()-1] == excess)
+                    return string.substr(1, string.length()-2);
+                return string;
+            }
+
+            inline std::string pad (std::string& string, char padding = '"')
+            {
+                    return (padding + string + padding);
+            }
+
+        };
+    }
+}

From d20bc7051a860463371a42a0f4cbada67b171952 Mon Sep 17 00:00:00 2001
From: The-EDev <farook@the-e-dev.com>
Date: Sun, 18 Oct 2020 01:56:07 +0300
Subject: [PATCH 2/7] removed include for mime type header

---
 include/crow.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/crow.h b/include/crow.h
index 98df4b64f..b57bb6632 100644
--- a/include/crow.h
+++ b/include/crow.h
@@ -11,7 +11,6 @@
 #include "crow/dumb_timer_queue.h"
 #include "crow/utility.h"
 #include "crow/common.h"
-#include "crow/mime_types.h"
 #include "crow/http_request.h"
 #include "crow/websocket.h"
 #include "crow/parser.h"

From e06942dfc420d315e2230e532de78e38c7e35492 Mon Sep 17 00:00:00 2001
From: The-EDev <farook@the-e-dev.com>
Date: Sun, 18 Oct 2020 02:36:39 +0300
Subject: [PATCH 3/7] added test funny enough, the test pointed out a mistake i
 made in the code XD

---
 include/crow/multipart.h | 10 +++++-----
 tests/unittest.cpp       | 31 +++++++++++++++++++++++++++++++
 2 files changed, 36 insertions(+), 5 deletions(-)

diff --git a/include/crow/multipart.h b/include/crow/multipart.h
index 3cc4a586b..eb79e1f4b 100644
--- a/include/crow/multipart.h
+++ b/include/crow/multipart.h
@@ -50,10 +50,10 @@ namespace crow
 
                 for (uint8_t i=0 ; i<parts.size(); i++)
                 {
-                    str << delimiter << std::endl;
+                    str << delimiter << crlf;
                     str << dump(i);
                 }
-                str << delimiter << "--" << std::endl;
+                str << delimiter << "--" << crlf;
                 return str.str();
             }
 
@@ -69,10 +69,10 @@ namespace crow
                     {
                         str << "; " << it.first << '=' << pad(it.second);
                     }
-                    str << std::endl;
+                    str << crlf;
                 }
-                str << std::endl;
-                str << item.body << std::endl;
+                str << crlf;
+                str << item.body << crlf;
                 return str.str();
             }
 
diff --git a/tests/unittest.cpp b/tests/unittest.cpp
index 91e04ad37..de3749a07 100644
--- a/tests/unittest.cpp
+++ b/tests/unittest.cpp
@@ -1284,6 +1284,37 @@ TEST(send_file)
         ASSERT_EQUAL(404, res.code);
     }
 }
+
+TEST(multipart)
+{
+    std::string test_string = "--CROW-BOUNDARY\r\nContent-Disposition: form-data; name=\"hello\"\r\n\r\nworld\r\n--CROW-BOUNDARY\r\nContent-Disposition: form-data; name=\"world\"\r\n\r\nhello\r\n--CROW-BOUNDARY\r\nContent-Disposition: form-data; name=\"multiline\"\r\n\r\ntext\ntext\ntext\r\n--CROW-BOUNDARY--\r\n";
+
+    SimpleApp app;
+
+    CROW_ROUTE(app, "/multipart")
+    ([](const crow::request& req, crow::response& res) {
+        multipart::message msg(req);
+        res.add_header("Content-Type", "multipart/form-data; boundary=CROW-BOUNDARY");
+        res.body = msg.dump();
+        res.end();
+    });
+
+    app.validate();
+
+    {
+        request req;
+        response res;
+
+        req.url = "/multipart";
+        req.add_header("Content-Type", "multipart/form-data; boundary=CROW-BOUNDARY");
+        req.body = test_string;
+
+        app.handle(req, res);
+
+        ASSERT_EQUAL(test_string, res.body);
+    }
+}
+
 int main()
 {
     return testmain();

From cb0915901f408bad8c3e6bacc57f5616a304c57d Mon Sep 17 00:00:00 2001
From: The-EDev <farook@the-e-dev.com>
Date: Sun, 18 Oct 2020 03:04:18 +0300
Subject: [PATCH 4/7] cleaned up code

---
 include/crow/multipart.h | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/include/crow/multipart.h b/include/crow/multipart.h
index eb79e1f4b..7deb8d45d 100644
--- a/include/crow/multipart.h
+++ b/include/crow/multipart.h
@@ -46,14 +46,14 @@ namespace crow
             const std::string dump()
             {
                 std::stringstream str;
-                std::string delimiter = "--" + boundary;
+                std::string delimiter = dd + boundary;
 
-                for (uint8_t i=0 ; i<parts.size(); i++)
+                for (uint i=0 ; i<parts.size(); i++)
                 {
                     str << delimiter << crlf;
                     str << dump(i);
                 }
-                str << delimiter << "--" << crlf;
+                str << delimiter << dd << crlf;
                 return str.str();
             }
 
@@ -89,13 +89,12 @@ namespace crow
 
           private:
 
-            std::string get_boundary(std::string header)
+            std::string get_boundary(const std::string& header)
             {
                 size_t found = header.find("boundary=");
                 if (found)
                     return header.substr(found+9);
-                static std::string empty;
-                return empty;
+                return std::string();
             }
 
             std::vector<part> parse_body(std::string body)
@@ -109,11 +108,12 @@ namespace crow
                   {
                       size_t found = body.find(delimiter);
                       std::string section = body.substr(0, found);
+
                       //+2 is the CRLF
                       //We don't check it and delete it so that the same delimiter can be used for
                       //the last delimiter (--delimiter--CRLF).
                       body.erase(0, found + delimiter.length() + 2);
-                      if (section != "")
+                      if (!section.empty())
                       {
                           sections.emplace_back(parse_section(section));
                       }
@@ -136,7 +136,7 @@ namespace crow
 
             void parse_section_head(std::string& lines, part& part)
             {
-                while (lines != "")
+                while (!lines.empty())
                 {
                     header to_add;
 
@@ -144,7 +144,7 @@ namespace crow
                     std::string line = lines.substr(0, found);
                     lines.erase(0, found+2);
                     //add the header if available
-                    if (line != "")
+                    if (!line.empty())
                     {
                         size_t found = line.find("; ");
                         std::string header = line.substr(0, found);
@@ -159,7 +159,7 @@ namespace crow
                     }
 
                     //add the parameters
-                    while (line != "")
+                    while (!line.empty())
                     {
                         size_t found = line.find("; ");
                         std::string param = line.substr(0, found);
@@ -178,14 +178,14 @@ namespace crow
                 }
             }
 
-            inline std::string trim (std::string& string, char excess = '"')
+            inline std::string trim (std::string& string, const char& excess = '"')
             {
                 if (string.length() > 1 && string[0] == excess && string[string.length()-1] == excess)
                     return string.substr(1, string.length()-2);
                 return string;
             }
 
-            inline std::string pad (std::string& string, char padding = '"')
+            inline std::string pad (std::string& string, const char& padding = '"')
             {
                     return (padding + string + padding);
             }

From 6a760ca09f65ecaafa54b0c362a1d5301f702ccd Mon Sep 17 00:00:00 2001
From: The-EDev <farook@the-e-dev.com>
Date: Sun, 18 Oct 2020 03:20:19 +0300
Subject: [PATCH 5/7] added simple example

---
 examples/example.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/examples/example.cpp b/examples/example.cpp
index 1355b03ec..58bbb12d6 100644
--- a/examples/example.cpp
+++ b/examples/example.cpp
@@ -163,6 +163,13 @@ int main()
         return std::string(512*1024, ' ');
     });
 
+    // Take a multipart/form-data request and print out its body
+    CROW_ROUTE(app,"/multipart")
+    ([](const crow::request& req){
+        crow::multipart::message msg(req);
+        CROW_LOG_INFO << "body of the first part " << msg.parts[0];
+    });
+
     // enables all log
     app.loglevel(crow::LogLevel::DEBUG);
     //crow::logger::setHandler(std::make_shared<ExampleLogHandler>());

From 8da6919617eb37d9cd379a269c54d52be1d803b7 Mon Sep 17 00:00:00 2001
From: The-EDev <farook@the-e-dev.com>
Date: Sun, 18 Oct 2020 03:38:50 +0300
Subject: [PATCH 6/7] fixed issue in example

---
 examples/example.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/examples/example.cpp b/examples/example.cpp
index 58bbb12d6..a2739a827 100644
--- a/examples/example.cpp
+++ b/examples/example.cpp
@@ -167,7 +167,8 @@ int main()
     CROW_ROUTE(app,"/multipart")
     ([](const crow::request& req){
         crow::multipart::message msg(req);
-        CROW_LOG_INFO << "body of the first part " << msg.parts[0];
+        CROW_LOG_INFO << "body of the first part " << msg.parts[0].body;
+        return "it works!";
     });
 
     // enables all log

From 7fa73907f82b26ae337d85fff168a3e69d68909b Mon Sep 17 00:00:00 2001
From: Farook Al-Sammarraie <farook@the-e-dev.com>
Date: Tue, 20 Oct 2020 10:21:29 +0300
Subject: [PATCH 7/7] removed main function

---
 tests/unittest.cpp | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tests/unittest.cpp b/tests/unittest.cpp
index 07475518a..022398b1e 100644
--- a/tests/unittest.cpp
+++ b/tests/unittest.cpp
@@ -1277,8 +1277,3 @@ TEST_CASE("multipart")
     REQUIRE(test_string == res.body);
   }
 }
-
-int main()
-{
-    return testmain();
-}