Mirror/docker-minecraft-server
1
0
Fork 0
mirror of https://github.com/itzg/docker-minecraft-server.git synced 2024-06-07 19:40:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[minecraft-server] Pass all command line arguments to start-configuration

Browse Source 
Regarding the minecraft-server image
The start script currently does not pass command line arguments to the next script. This makes it so server admins can't easily update their server to 1.13.2 by passing --forceUpgrade as an extra parameter after specifying the docker image. With this change it works as intended.

Proof that the arguments did not get added before and do now:
* Add this line to the start-minecraftFinalSetup script: `echo "Running with: mc-server-runner ${bootstrapArgs} java $JVM_XX_OPTS $JVM_OPTS -jar $SERVER ""$@"" $EXTRA_ARGS"`
* Build the image
* Run the image with extra arguments `--test`
* See this printed: `Running with: mc-server-runner -jar minecraft_server.1.13.2.jar`
* Update to this PR
* Build the image
* See this printed: `Running with: mc-server-runner -jar minecraft_server.1.13.2.jar --test`
This commit is contained in:
Autom3 2018-10-23 23:00:23 +02:00 committed by GitHub
parent 7be2020879
commit 3f3a2d8433
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
minecraft-server/start
View File

@ -16,7 +16,7 @@ if [ $(id -u) = 0 ]; then
chown -R minecraft:minecraft /data
fi
exec su-exec minecraft:minecraft /start-configuration
exec su-exec minecraft:minecraft /start-configuration $@
else
exec /start-configuration
exec /start-configuration $@
fi