From 9b538267a1fd7df006e09fe7363a8e313a09ec8f Mon Sep 17 00:00:00 2001 From: Geoff Bourne Date: Sun, 5 Mar 2023 08:55:19 -0600 Subject: [PATCH] Ensure Modrinth support specifies paper/purpur loader as needed (#1990) --- Dockerfile | 2 +- scripts/start-setupModpack | 13 ++++++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/Dockerfile b/Dockerfile index 3fe4b44d..6fc5096d 100644 --- a/Dockerfile +++ b/Dockerfile @@ -46,7 +46,7 @@ RUN easy-add --var os=${TARGETOS} --var arch=${TARGETARCH}${TARGETVARIANT} \ --var version=0.1.1 --var app=maven-metadata-release --file {{.app}} \ --from https://github.com/itzg/{{.app}}/releases/download/{{.version}}/{{.app}}_{{.version}}_{{.os}}_{{.arch}}.tar.gz -ARG MC_HELPER_VERSION=1.25.6 +ARG MC_HELPER_VERSION=1.25.9 ARG MC_HELPER_BASE_URL=https://github.com/itzg/mc-image-helper/releases/download/${MC_HELPER_VERSION} RUN curl -fsSL ${MC_HELPER_BASE_URL}/mc-image-helper-${MC_HELPER_VERSION}.tgz \ | tar -C /usr/share -zxf - \ diff --git a/scripts/start-setupModpack b/scripts/start-setupModpack index bbba2043..e1467b8d 100755 --- a/scripts/start-setupModpack +++ b/scripts/start-setupModpack @@ -183,7 +183,7 @@ esac fi } -function genericPacks() { +function handleGenericPacks() { : "${GENERIC_PACKS:=${GENERIC_PACK}}" : "${GENERIC_PACKS_PREFIX:=}" : "${GENERIC_PACKS_SUFFIX:=}" @@ -267,7 +267,7 @@ function genericPacks() { fi } -function modrinthProjects() { +function handleModrinthProjects() { : "${MODRINTH_PROJECTS:=}" : "${MODRINTH_DOWNLOAD_OPTIONAL_DEPENDENCIES:=true}" : "${MODRINTH_ALLOWED_VERSION_TYPE:=release}" @@ -275,8 +275,11 @@ function modrinthProjects() { if [[ $MODRINTH_PROJECTS ]] && isFamily HYBRID FORGE FABRIC SPIGOT; then if isFamily HYBRID FORGE; then loader=forge + elif isFaily FABRIC; then + loader=fabric else - loader="${FAMILY,,}" + # we're left with Bukkit/Spigot down-lines where plugins seem to be + loader="${TYPE,,}" fi mc-image-helper modrinth \ --output-directory=/data \ @@ -294,8 +297,8 @@ handleModpackListOrFile handleCurseForgeManifest -genericPacks +handleGenericPacks -modrinthProjects +handleModrinthProjects exec "${SCRIPTS:-/}start-setupModconfig" "$@"