From bfdfc5d3cb536bfe7957216bf1ac58708e69dc97 Mon Sep 17 00:00:00 2001 From: fabioswartz Date: Fri, 30 Dec 2016 11:30:33 +0000 Subject: [PATCH] Cleaning common.js Former-commit-id: a86bbc411eb4a49a586993e1b4835c6eba6604ca --- _embed/public/js/common.js | 31 ++++++++++++------------------- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/_embed/public/js/common.js b/_embed/public/js/common.js index f3dd8a57..b5ba0040 100644 --- a/_embed/public/js/common.js +++ b/_embed/public/js/common.js @@ -6,17 +6,13 @@ var tempID = "_fm_internal_temporary_id", // Removes an element, if exists, from an array Array.prototype.removeElement = function(element) { var i = this.indexOf(element); - if (i != -1) { - this.splice(i, 1); - } + if (i != -1) this.splice(i, 1); } // Replaces an element inside an array by another -Array.prototype.replaceElement = function(begin, end) { - var i = this.indexOf(begin); - if (i != -1) { - this[i] = end; - } +Array.prototype.replaceElement = function(oldElement, newElement) { + var i = this.indexOf(oldElement); + if (i != -1) this[i] = newElement; } // Sends a costum event to itself @@ -32,8 +28,8 @@ Document.prototype.getCookie = function(name) { // Changes a button to the loading animation Element.prototype.changeToLoading = function() { - let element = this; - let originalText = element.innerHTML; + let element = this, + originalText = element.innerHTML; element.style.opacity = 0; @@ -53,9 +49,7 @@ Element.prototype.changeToDone = function(error, html) { this.innerHTML = html; this.style.opacity = null; - if (selectedItems.length == 0 && document.getElementById('listing')) { - document.sendCostumEvent('changed-selected'); - } + if (selectedItems.length == 0 && document.getElementById('listing')) document.sendCostumEvent('changed-selected'); } let secondStep = () => { @@ -64,10 +58,9 @@ Element.prototype.changeToDone = function(error, html) { } let firstStep = () => { + this.innerHTML = 'done'; if (error) { - this.innerHTML = 'close'; - } else { - this.innerHTML = 'done'; + this.innerHTML = 'close'; } this.style.opacity = 1; @@ -81,8 +74,8 @@ Element.prototype.changeToDone = function(error, html) { function getCSSRule(ruleName) { ruleName = ruleName.toLowerCase(); - var result = null; - var find = Array.prototype.find; + var result = null, + find = Array.prototype.find; find.call(document.styleSheets, styleSheet => { result = find.call(styleSheet.cssRules, cssRule => { @@ -266,4 +259,4 @@ document.addEventListener("DOMContentLoaded", function(event) { } return false; -}); \ No newline at end of file +});