From dead024e53c276df18ca60f9c7af3cc57af06c85 Mon Sep 17 00:00:00 2001 From: 1138-4EB <1138-4EB@users.noreply.github.com> Date: Tue, 7 Aug 2018 13:53:52 +0100 Subject: [PATCH] add pull request template (#501) Related to #477. Former-commit-id: f3020544c0b03295d5c4c79a678a4a1acc47884e [formerly 10c8b8febfa720d1e719f5e4735259b6427b9df0] [formerly 3d0b90a6b6c62bed99d8347066befff8a29f4525 [formerly 8186e8f02f83c892e3f75c3784bc0787e982272a]] Former-commit-id: ccbd134d4e7d8eb7a362a2e34fa2828f2b86766d [formerly 2f9b979b97a8086136cdf36c68cdaeb2b36ef7da] Former-commit-id: 6855aafd45b5c526b91fd3acdd95af4fec68175f --- .github/PULL_REQUEST_TEMPLATE.md | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..d59412e1 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,16 @@ +**Description** +Please explain the changes you made here. +If the feature changes current behaviour, explain why your solution is better. + +:rotating_light: Before submitting your PR, please read [community](https://github.com/filebrowser/community), and indicate which issues (in any of the repos) are either fixed or closed by this PR. See [GitHub Help: Closing issues using keywords](https://help.github.com/articles/closing-issues-via-commit-messages/). + +- [ ] DO make sure you are requesting to **pull a topic/feature/bugfix branch** (right side). Don't request your master! +- [ ] DO make sure you are making a pull request against the **master branch** (left side). Also you should start *your branch* off *our master*. +- [ ] DO make sure that File Browser can be successfully built. See [builds](https://github.com/filebrowser/community/blob/master/builds.md) and [development](https://github.com/filebrowser/community/blob/master/development.md). +- [ ] DO make sure that related issues are opened in other repositories. I.e., the frontend, caddy plugins or the web page need to be updated accordingly. +- [ ] AVOID breaking the continuous integration build. + +**Further comments** +If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did, what alternatives you considered, etc. + +:heart: Thank you!