2019-08-30 18:33:25 +00:00
/ *
Copyright 2019 The Kubernetes Authors .
Licensed under the Apache License , Version 2.0 ( the "License" ) ;
you may not use this file except in compliance with the License .
You may obtain a copy of the License at
http : //www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing , software
distributed under the License is distributed on an "AS IS" BASIS ,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND , either express or implied .
See the License for the specific language governing permissions and
limitations under the License .
* /
package schema
import (
"fmt"
"reflect"
"regexp"
"sort"
"k8s.io/apimachinery/pkg/util/validation/field"
)
var intOrStringAnyOf = [ ] NestedValueValidation {
{ ForbiddenGenerics : Generic {
Type : "integer" ,
} } ,
{ ForbiddenGenerics : Generic {
Type : "string" ,
} } ,
}
type level int
const (
rootLevel level = iota
itemLevel
fieldLevel
)
// ValidateStructural checks that s is a structural schema with the invariants:
//
// * structurality: both `ForbiddenGenerics` and `ForbiddenExtensions` only have zero values, with the two exceptions for IntOrString.
// * RawExtension: for every schema with `x-kubernetes-embedded-resource: true`, `x-kubernetes-preserve-unknown-fields: true` and `type: object` are set
// * IntOrString: for `x-kubernetes-int-or-string: true` either `type` is empty under `anyOf` and `allOf` or the schema structure is one of these:
//
// 1) anyOf:
// - type: integer
// - type: string
// 2) allOf:
// - anyOf:
// - type: integer
// - type: string
// - ... zero or more
//
// * every specified field or array in s is also specified outside of value validation.
// * metadata at the root can only restrict the name and generateName, and not be specified at all in nested contexts.
// * additionalProperties at the root is not allowed.
2019-09-27 21:51:53 +00:00
func ValidateStructural ( fldPath * field . Path , s * Structural ) field . ErrorList {
2019-08-30 18:33:25 +00:00
allErrs := field . ErrorList { }
allErrs = append ( allErrs , validateStructuralInvariants ( s , rootLevel , fldPath ) ... )
allErrs = append ( allErrs , validateStructuralCompleteness ( s , fldPath ) ... )
// sort error messages. Otherwise, the errors slice will change every time due to
// maps in the types and randomized iteration.
sort . Slice ( allErrs , func ( i , j int ) bool {
return allErrs [ i ] . Error ( ) < allErrs [ j ] . Error ( )
} )
return allErrs
}
// validateStructuralInvariants checks the invariants of a structural schema.
func validateStructuralInvariants ( s * Structural , lvl level , fldPath * field . Path ) field . ErrorList {
if s == nil {
return nil
}
allErrs := field . ErrorList { }
if s . Type == "array" && s . Items == nil {
allErrs = append ( allErrs , field . Required ( fldPath . Child ( "items" ) , "must be specified" ) )
}
allErrs = append ( allErrs , validateStructuralInvariants ( s . Items , itemLevel , fldPath . Child ( "items" ) ) ... )
for k , v := range s . Properties {
allErrs = append ( allErrs , validateStructuralInvariants ( & v , fieldLevel , fldPath . Child ( "properties" ) . Key ( k ) ) ... )
}
allErrs = append ( allErrs , validateGeneric ( & s . Generic , lvl , fldPath ) ... )
allErrs = append ( allErrs , validateExtensions ( & s . Extensions , fldPath ) ... )
// detect the two IntOrString exceptions:
// 1) anyOf:
// - type: integer
// - type: string
// 2) allOf:
// - anyOf:
// - type: integer
// - type: string
// - ... zero or more
skipAnyOf := isIntOrStringAnyOfPattern ( s )
skipFirstAllOfAnyOf := isIntOrStringAllOfPattern ( s )
allErrs = append ( allErrs , validateValueValidation ( s . ValueValidation , skipAnyOf , skipFirstAllOfAnyOf , lvl , fldPath ) ... )
checkMetadata := ( lvl == rootLevel ) || s . XEmbeddedResource
if s . XEmbeddedResource && s . Type != "object" {
if len ( s . Type ) == 0 {
allErrs = append ( allErrs , field . Required ( fldPath . Child ( "type" ) , "must be object if x-kubernetes-embedded-resource is true" ) )
} else {
allErrs = append ( allErrs , field . Invalid ( fldPath . Child ( "type" ) , s . Type , "must be object if x-kubernetes-embedded-resource is true" ) )
}
} else if len ( s . Type ) == 0 && ! s . Extensions . XIntOrString && ! s . Extensions . XPreserveUnknownFields {
switch lvl {
case rootLevel :
allErrs = append ( allErrs , field . Required ( fldPath . Child ( "type" ) , "must not be empty at the root" ) )
case itemLevel :
allErrs = append ( allErrs , field . Required ( fldPath . Child ( "type" ) , "must not be empty for specified array items" ) )
case fieldLevel :
allErrs = append ( allErrs , field . Required ( fldPath . Child ( "type" ) , "must not be empty for specified object fields" ) )
}
}
if s . XEmbeddedResource && s . AdditionalProperties != nil {
allErrs = append ( allErrs , field . Forbidden ( fldPath . Child ( "additionalProperties" ) , "must not be used if x-kubernetes-embedded-resource is set" ) )
}
if lvl == rootLevel && len ( s . Type ) > 0 && s . Type != "object" {
allErrs = append ( allErrs , field . Invalid ( fldPath . Child ( "type" ) , s . Type , "must be object at the root" ) )
}
// restrict metadata schemas to name and generateName only
if kind , found := s . Properties [ "kind" ] ; found && checkMetadata {
if kind . Type != "string" {
allErrs = append ( allErrs , field . Invalid ( fldPath . Child ( "properties" ) . Key ( "kind" ) . Child ( "type" ) , kind . Type , "must be string" ) )
}
}
if apiVersion , found := s . Properties [ "apiVersion" ] ; found && checkMetadata {
if apiVersion . Type != "string" {
allErrs = append ( allErrs , field . Invalid ( fldPath . Child ( "properties" ) . Key ( "apiVersion" ) . Child ( "type" ) , apiVersion . Type , "must be string" ) )
}
}
if metadata , found := s . Properties [ "metadata" ] ; found && checkMetadata {
if metadata . Type != "object" {
allErrs = append ( allErrs , field . Invalid ( fldPath . Child ( "properties" ) . Key ( "metadata" ) . Child ( "type" ) , metadata . Type , "must be object" ) )
}
}
if metadata , found := s . Properties [ "metadata" ] ; found && lvl == rootLevel {
// metadata is a shallow copy. We can mutate it.
_ , foundName := metadata . Properties [ "name" ]
_ , foundGenerateName := metadata . Properties [ "generateName" ]
if foundName && foundGenerateName && len ( metadata . Properties ) == 2 {
metadata . Properties = nil
} else if ( foundName || foundGenerateName ) && len ( metadata . Properties ) == 1 {
metadata . Properties = nil
}
metadata . Type = ""
metadata . Default . Object = nil // this is checked in API validation (and also tested)
if metadata . ValueValidation == nil {
metadata . ValueValidation = & ValueValidation { }
}
if ! reflect . DeepEqual ( metadata , Structural { ValueValidation : & ValueValidation { } } ) {
// TODO: this is actually a field.Invalid error, but we cannot do JSON serialization of metadata here to get a proper message
allErrs = append ( allErrs , field . Forbidden ( fldPath . Child ( "properties" ) . Key ( "metadata" ) , "must not specify anything other than name and generateName, but metadata is implicitly specified" ) )
}
}
2019-09-27 21:51:53 +00:00
if s . XEmbeddedResource && ! s . XPreserveUnknownFields && len ( s . Properties ) == 0 {
2019-08-30 18:33:25 +00:00
allErrs = append ( allErrs , field . Required ( fldPath . Child ( "properties" ) , "must not be empty if x-kubernetes-embedded-resource is true without x-kubernetes-preserve-unknown-fields" ) )
}
return allErrs
}
func isIntOrStringAnyOfPattern ( s * Structural ) bool {
if s == nil || s . ValueValidation == nil {
return false
}
return len ( s . ValueValidation . AnyOf ) == 2 && reflect . DeepEqual ( s . ValueValidation . AnyOf , intOrStringAnyOf )
}
func isIntOrStringAllOfPattern ( s * Structural ) bool {
if s == nil || s . ValueValidation == nil {
return false
}
return len ( s . ValueValidation . AllOf ) >= 1 && len ( s . ValueValidation . AllOf [ 0 ] . AnyOf ) == 2 && reflect . DeepEqual ( s . ValueValidation . AllOf [ 0 ] . AnyOf , intOrStringAnyOf )
}
// validateGeneric checks the generic fields of a structural schema.
func validateGeneric ( g * Generic , lvl level , fldPath * field . Path ) field . ErrorList {
if g == nil {
return nil
}
allErrs := field . ErrorList { }
if g . AdditionalProperties != nil {
if lvl == rootLevel {
allErrs = append ( allErrs , field . Forbidden ( fldPath . Child ( "additionalProperties" ) , "must not be used at the root" ) )
}
if g . AdditionalProperties . Structural != nil {
allErrs = append ( allErrs , validateStructuralInvariants ( g . AdditionalProperties . Structural , fieldLevel , fldPath . Child ( "additionalProperties" ) ) ... )
}
}
return allErrs
}
// validateExtensions checks Kubernetes vendor extensions of a structural schema.
func validateExtensions ( x * Extensions , fldPath * field . Path ) field . ErrorList {
allErrs := field . ErrorList { }
if x . XIntOrString && x . XPreserveUnknownFields {
allErrs = append ( allErrs , field . Invalid ( fldPath . Child ( "x-kubernetes-preserve-unknown-fields" ) , x . XPreserveUnknownFields , "must be false if x-kubernetes-int-or-string is true" ) )
}
if x . XIntOrString && x . XEmbeddedResource {
allErrs = append ( allErrs , field . Invalid ( fldPath . Child ( "x-kubernetes-embedded-resource" ) , x . XEmbeddedResource , "must be false if x-kubernetes-int-or-string is true" ) )
}
return allErrs
}
// validateValueValidation checks the value validation in a structural schema.
func validateValueValidation ( v * ValueValidation , skipAnyOf , skipFirstAllOfAnyOf bool , lvl level , fldPath * field . Path ) field . ErrorList {
if v == nil {
return nil
}
allErrs := field . ErrorList { }
if ! skipAnyOf {
for i := range v . AnyOf {
allErrs = append ( allErrs , validateNestedValueValidation ( & v . AnyOf [ i ] , false , false , lvl , fldPath . Child ( "anyOf" ) . Index ( i ) ) ... )
}
}
for i := range v . AllOf {
skipAnyOf := false
if skipFirstAllOfAnyOf && i == 0 {
skipAnyOf = true
}
allErrs = append ( allErrs , validateNestedValueValidation ( & v . AllOf [ i ] , skipAnyOf , false , lvl , fldPath . Child ( "allOf" ) . Index ( i ) ) ... )
}
for i := range v . OneOf {
allErrs = append ( allErrs , validateNestedValueValidation ( & v . OneOf [ i ] , false , false , lvl , fldPath . Child ( "oneOf" ) . Index ( i ) ) ... )
}
allErrs = append ( allErrs , validateNestedValueValidation ( v . Not , false , false , lvl , fldPath . Child ( "not" ) ) ... )
if len ( v . Pattern ) > 0 {
if _ , err := regexp . Compile ( v . Pattern ) ; err != nil {
allErrs = append ( allErrs , field . Invalid ( fldPath . Child ( "pattern" ) , v . Pattern , fmt . Sprintf ( "must be a valid regular expression, but isn't: %v" , err ) ) )
}
}
return allErrs
}
// validateNestedValueValidation checks the nested value validation under a logic junctor in a structural schema.
func validateNestedValueValidation ( v * NestedValueValidation , skipAnyOf , skipAllOfAnyOf bool , lvl level , fldPath * field . Path ) field . ErrorList {
if v == nil {
return nil
}
allErrs := field . ErrorList { }
allErrs = append ( allErrs , validateValueValidation ( & v . ValueValidation , skipAnyOf , skipAllOfAnyOf , lvl , fldPath ) ... )
allErrs = append ( allErrs , validateNestedValueValidation ( v . Items , false , false , lvl , fldPath . Child ( "items" ) ) ... )
for k , fld := range v . Properties {
allErrs = append ( allErrs , validateNestedValueValidation ( & fld , false , false , fieldLevel , fldPath . Child ( "properties" ) . Key ( k ) ) ... )
}
if len ( v . ForbiddenGenerics . Type ) > 0 {
allErrs = append ( allErrs , field . Forbidden ( fldPath . Child ( "type" ) , "must be empty to be structural" ) )
}
if v . ForbiddenGenerics . AdditionalProperties != nil {
allErrs = append ( allErrs , field . Forbidden ( fldPath . Child ( "additionalProperties" ) , "must be undefined to be structural" ) )
}
if v . ForbiddenGenerics . Default . Object != nil {
allErrs = append ( allErrs , field . Forbidden ( fldPath . Child ( "default" ) , "must be undefined to be structural" ) )
}
if len ( v . ForbiddenGenerics . Title ) > 0 {
allErrs = append ( allErrs , field . Forbidden ( fldPath . Child ( "title" ) , "must be empty to be structural" ) )
}
if len ( v . ForbiddenGenerics . Description ) > 0 {
allErrs = append ( allErrs , field . Forbidden ( fldPath . Child ( "description" ) , "must be empty to be structural" ) )
}
if v . ForbiddenGenerics . Nullable {
allErrs = append ( allErrs , field . Forbidden ( fldPath . Child ( "nullable" ) , "must be false to be structural" ) )
}
if v . ForbiddenExtensions . XPreserveUnknownFields {
allErrs = append ( allErrs , field . Forbidden ( fldPath . Child ( "x-kubernetes-preserve-unknown-fields" ) , "must be false to be structural" ) )
}
if v . ForbiddenExtensions . XEmbeddedResource {
allErrs = append ( allErrs , field . Forbidden ( fldPath . Child ( "x-kubernetes-embedded-resource" ) , "must be false to be structural" ) )
}
if v . ForbiddenExtensions . XIntOrString {
allErrs = append ( allErrs , field . Forbidden ( fldPath . Child ( "x-kubernetes-int-or-string" ) , "must be false to be structural" ) )
}
2019-09-27 21:51:53 +00:00
if len ( v . ForbiddenExtensions . XListMapKeys ) > 0 {
allErrs = append ( allErrs , field . Forbidden ( fldPath . Child ( "x-kubernetes-list-map-keys" ) , "must be empty to be structural" ) )
}
if v . ForbiddenExtensions . XListType != nil {
allErrs = append ( allErrs , field . Forbidden ( fldPath . Child ( "x-kubernetes-list-type" ) , "must be undefined to be structural" ) )
}
2019-12-12 01:27:03 +00:00
if v . ForbiddenExtensions . XMapType != nil {
allErrs = append ( allErrs , field . Forbidden ( fldPath . Child ( "x-kubernetes-map-type" ) , "must be undefined to be structural" ) )
}
2019-08-30 18:33:25 +00:00
// forbid reasoning about metadata because it can lead to metadata restriction we don't want
if _ , found := v . Properties [ "metadata" ] ; found {
allErrs = append ( allErrs , field . Forbidden ( fldPath . Child ( "properties" ) . Key ( "metadata" ) , "must not be specified in a nested context" ) )
}
return allErrs
}