2019-09-27 21:51:53 +00:00
// +build !providerless
2019-08-30 18:33:25 +00:00
/ *
Copyright 2017 The Kubernetes Authors .
Licensed under the Apache License , Version 2.0 ( the "License" ) ;
you may not use this file except in compliance with the License .
You may obtain a copy of the License at
http : //www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing , software
distributed under the License is distributed on an "AS IS" BASIS ,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND , either express or implied .
See the License for the specific language governing permissions and
limitations under the License .
* /
package gce
import (
"context"
2019-09-27 21:51:53 +00:00
"encoding/json"
2019-08-30 18:33:25 +00:00
"fmt"
2019-12-12 01:27:03 +00:00
"sort"
2019-08-30 18:33:25 +00:00
"strconv"
"strings"
"github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud"
2019-12-12 01:27:03 +00:00
"github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud/meta"
2021-02-22 20:08:19 +00:00
"github.com/google/go-cmp/cmp"
2019-08-30 18:33:25 +00:00
compute "google.golang.org/api/compute/v1"
"k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/sets"
2019-09-27 21:51:53 +00:00
cloudprovider "k8s.io/cloud-provider"
2019-08-30 18:33:25 +00:00
servicehelpers "k8s.io/cloud-provider/service/helpers"
2020-08-10 17:43:49 +00:00
"k8s.io/klog/v2"
2019-08-30 18:33:25 +00:00
)
const (
2019-09-27 21:51:53 +00:00
// Used to list instances in all states(RUNNING and other) - https://cloud.google.com/compute/docs/reference/rest/v1/instanceGroups/listInstances
2019-08-30 18:33:25 +00:00
allInstances = "ALL"
2020-03-26 21:07:15 +00:00
// ILBFinalizerV1 key is used to identify ILB services whose resources are managed by service controller.
ILBFinalizerV1 = "gke.networking.io/l4-ilb-v1"
// ILBFinalizerV2 is the finalizer used by newer controllers that implement Internal LoadBalancer services.
ILBFinalizerV2 = "gke.networking.io/l4-ilb-v2"
2020-04-19 06:53:00 +00:00
// maxInstancesPerInstanceGroup defines maximum number of VMs per InstanceGroup.
maxInstancesPerInstanceGroup = 1000
2019-08-30 18:33:25 +00:00
)
func ( g * Cloud ) ensureInternalLoadBalancer ( clusterName , clusterID string , svc * v1 . Service , existingFwdRule * compute . ForwardingRule , nodes [ ] * v1 . Node ) ( * v1 . LoadBalancerStatus , error ) {
2020-03-26 21:07:15 +00:00
if g . AlphaFeatureGate . Enabled ( AlphaFeatureILBSubsets ) && existingFwdRule == nil {
// When ILBSubsets is enabled, new ILB services will not be processed here.
// Services that have existing GCE resources created by this controller will continue to update.
g . eventRecorder . Eventf ( svc , v1 . EventTypeNormal , "SkippingEnsureInternalLoadBalancer" ,
"Skipped ensureInternalLoadBalancer since %s feature is enabled." , AlphaFeatureILBSubsets )
return nil , cloudprovider . ImplementedElsewhere
}
if hasFinalizer ( svc , ILBFinalizerV2 ) {
// Another controller is handling the resources for this service.
g . eventRecorder . Eventf ( svc , v1 . EventTypeNormal , "SkippingEnsureInternalLoadBalancer" ,
"Skipped ensureInternalLoadBalancer as service contains '%s' finalizer." , ILBFinalizerV2 )
2019-09-27 21:51:53 +00:00
return nil , cloudprovider . ImplementedElsewhere
2019-08-30 18:33:25 +00:00
}
2020-06-23 22:12:14 +00:00
2020-08-10 17:43:49 +00:00
nm := types . NamespacedName { Name : svc . Name , Namespace : svc . Namespace }
var serviceState L4ILBServiceState
// Mark the service InSuccess state as false to begin with.
// This will be updated to true if the VIP is configured successfully.
serviceState . InSuccess = false
defer func ( ) {
g . metricsCollector . SetL4ILBService ( nm . String ( ) , serviceState )
} ( )
2020-06-23 22:12:14 +00:00
loadBalancerName := g . GetLoadBalancerName ( context . TODO ( ) , clusterName , svc )
klog . V ( 2 ) . Infof ( "ensureInternalLoadBalancer(%v): Attaching %q finalizer" , loadBalancerName , ILBFinalizerV1 )
2020-03-26 21:07:15 +00:00
if err := addFinalizer ( svc , g . client . CoreV1 ( ) , ILBFinalizerV1 ) ; err != nil {
klog . Errorf ( "Failed to attach finalizer '%s' on service %s/%s - %v" , ILBFinalizerV1 , svc . Namespace , svc . Name , err )
return nil , err
}
2019-09-27 21:51:53 +00:00
2019-12-12 01:27:03 +00:00
ports , _ , protocol := getPortsAndProtocol ( svc . Spec . Ports )
2019-08-30 18:33:25 +00:00
if protocol != v1 . ProtocolTCP && protocol != v1 . ProtocolUDP {
return nil , fmt . Errorf ( "Invalid protocol %s, only TCP and UDP are supported" , string ( protocol ) )
}
scheme := cloud . SchemeInternal
2019-09-27 21:51:53 +00:00
options := getILBOptions ( svc )
2020-08-10 17:43:49 +00:00
if g . IsLegacyNetwork ( ) {
2019-09-27 21:51:53 +00:00
g . eventRecorder . Event ( svc , v1 . EventTypeWarning , "ILBOptionsIgnored" , "Internal LoadBalancer options are not supported with Legacy Networks." )
options = ILBOptions { }
}
2019-12-12 01:27:03 +00:00
if ! g . AlphaFeatureGate . Enabled ( AlphaFeatureILBCustomSubnet ) {
if options . SubnetName != "" {
g . eventRecorder . Event ( svc , v1 . EventTypeWarning , "ILBCustomSubnetOptionIgnored" , "Internal LoadBalancer CustomSubnet options ignored as the feature gate is disabled." )
options . SubnetName = ""
}
}
2019-09-27 21:51:53 +00:00
2019-08-30 18:33:25 +00:00
sharedBackend := shareBackendService ( svc )
backendServiceName := makeBackendServiceName ( loadBalancerName , clusterID , sharedBackend , scheme , protocol , svc . Spec . SessionAffinity )
backendServiceLink := g . getBackendServiceLink ( backendServiceName )
// Ensure instance groups exist and nodes are assigned to groups
igName := makeInstanceGroupName ( clusterID )
igLinks , err := g . ensureInternalInstanceGroups ( igName , nodes )
if err != nil {
return nil , err
}
// Get existing backend service (if exists)
var existingBackendService * compute . BackendService
if existingFwdRule != nil && existingFwdRule . BackendService != "" {
existingBSName := getNameFromLink ( existingFwdRule . BackendService )
if existingBackendService , err = g . GetRegionBackendService ( existingBSName , g . region ) ; err != nil && ! isNotFound ( err ) {
return nil , err
}
}
// Lock the sharedResourceLock to prevent any deletions of shared resources while assembling shared resources here
g . sharedResourceLock . Lock ( )
defer g . sharedResourceLock . Unlock ( )
// Ensure health check exists before creating the backend service. The health check is shared
// if externalTrafficPolicy=Cluster.
sharedHealthCheck := ! servicehelpers . RequestsOnlyLocalTraffic ( svc )
hcName := makeHealthCheckName ( loadBalancerName , clusterID , sharedHealthCheck )
hcPath , hcPort := GetNodesHealthCheckPath ( ) , GetNodesHealthCheckPort ( )
if ! sharedHealthCheck {
// Service requires a special health check, retrieve the OnlyLocal port & path
hcPath , hcPort = servicehelpers . GetServiceHealthCheckPathPort ( svc )
}
hc , err := g . ensureInternalHealthCheck ( hcName , nm , sharedHealthCheck , hcPath , hcPort )
if err != nil {
return nil , err
}
2019-12-12 01:27:03 +00:00
subnetworkURL := g . SubnetworkURL ( )
if g . AlphaFeatureGate . Enabled ( AlphaFeatureILBCustomSubnet ) {
// If this feature is enabled, changes to subnet annotation will be
// picked up and reflected in the forwarding rule.
// Removing the annotation will set the forwarding rule to use the default subnet.
if options . SubnetName != "" {
subnetworkURL = gceSubnetworkURL ( "" , g . networkProjectID , g . region , options . SubnetName )
}
} else {
// TODO(84885) remove this once ILBCustomSubnet goes beta.
if existingFwdRule != nil && existingFwdRule . Subnetwork != "" {
// If the ILB already exists, continue using the subnet that it's already using.
// This is to support existing ILBs that were setup using the wrong subnet - https://github.com/kubernetes/kubernetes/pull/57861
subnetworkURL = existingFwdRule . Subnetwork
}
}
2019-08-30 18:33:25 +00:00
// Determine IP which will be used for this LB. If no forwarding rule has been established
// or specified in the Service spec, then requestedIP = "".
2019-12-12 01:27:03 +00:00
ipToUse := ilbIPToUse ( svc , existingFwdRule , subnetworkURL )
2019-08-30 18:33:25 +00:00
2019-12-12 01:27:03 +00:00
klog . V ( 2 ) . Infof ( "ensureInternalLoadBalancer(%v): Using subnet %s for LoadBalancer IP %s" , loadBalancerName , options . SubnetName , ipToUse )
2019-08-30 18:33:25 +00:00
var addrMgr * addressManager
// If the network is not a legacy network, use the address manager
if ! g . IsLegacyNetwork ( ) {
2019-12-12 01:27:03 +00:00
addrMgr = newAddressManager ( g , nm . String ( ) , g . Region ( ) , subnetworkURL , loadBalancerName , ipToUse , cloud . SchemeInternal )
2019-08-30 18:33:25 +00:00
ipToUse , err = addrMgr . HoldAddress ( )
if err != nil {
return nil , err
}
klog . V ( 2 ) . Infof ( "ensureInternalLoadBalancer(%v): reserved IP %q for the forwarding rule" , loadBalancerName , ipToUse )
2021-01-14 00:37:06 +00:00
defer func ( ) {
// Release the address if all resources were created successfully, or if we error out.
if err := addrMgr . ReleaseAddress ( ) ; err != nil {
klog . Errorf ( "ensureInternalLoadBalancer: failed to release address reservation, possibly causing an orphan: %v" , err )
}
} ( )
2019-08-30 18:33:25 +00:00
}
// Ensure firewall rules if necessary
if err = g . ensureInternalFirewalls ( loadBalancerName , ipToUse , clusterID , nm , svc , strconv . Itoa ( int ( hcPort ) ) , sharedHealthCheck , nodes ) ; err != nil {
return nil , err
}
2020-08-10 17:43:49 +00:00
fwdRuleDescription := & forwardingRuleDescription { ServiceName : nm . String ( ) }
fwdRuleDescriptionString , err := fwdRuleDescription . marshal ( )
if err != nil {
return nil , err
}
newFwdRule := & compute . ForwardingRule {
Name : loadBalancerName ,
Description : fwdRuleDescriptionString ,
IPAddress : ipToUse ,
BackendService : backendServiceLink ,
Ports : ports ,
IPProtocol : string ( protocol ) ,
LoadBalancingScheme : string ( scheme ) ,
2019-09-27 21:51:53 +00:00
// Given that CreateGCECloud will attempt to determine the subnet based off the network,
// the subnetwork should rarely be unknown.
2020-08-10 17:43:49 +00:00
Subnetwork : subnetworkURL ,
Network : g . networkURL ,
2019-09-27 21:51:53 +00:00
}
if options . AllowGlobalAccess {
2020-08-10 17:43:49 +00:00
newFwdRule . AllowGlobalAccess = options . AllowGlobalAccess
2019-09-27 21:51:53 +00:00
}
2020-12-01 01:06:26 +00:00
fwdRuleDeleted := false
if existingFwdRule != nil && ! forwardingRulesEqual ( existingFwdRule , newFwdRule ) {
// Delete existing forwarding rule before making changes to the backend service. For example - changing protocol
// of backend service without first deleting forwarding rule will throw an error since the linked forwarding
// rule would show the old protocol.
2021-02-22 20:08:19 +00:00
frDiff := cmp . Diff ( existingFwdRule , newFwdRule )
klog . V ( 2 ) . Infof ( "ensureInternalLoadBalancer(%v): forwarding rule changed - Existing - %+v\n, New - %+v\n, Diff(-existing, +new) - %s\n. Deleting existing forwarding rule." , loadBalancerName , existingFwdRule , newFwdRule , frDiff )
2020-12-01 01:06:26 +00:00
if err = ignoreNotFound ( g . DeleteRegionForwardingRule ( loadBalancerName , g . region ) ) ; err != nil {
return nil , err
}
fwdRuleDeleted = true
}
bsDescription := makeBackendServiceDescription ( nm , sharedBackend )
err = g . ensureInternalBackendService ( backendServiceName , bsDescription , svc . Spec . SessionAffinity , scheme , protocol , igLinks , hc . SelfLink )
if err != nil {
2019-09-27 21:51:53 +00:00
return nil , err
2019-08-30 18:33:25 +00:00
}
2020-12-01 01:06:26 +00:00
if fwdRuleDeleted || existingFwdRule == nil {
2021-02-22 20:08:19 +00:00
// existing rule has been deleted, pass in nil
if err := g . ensureInternalForwardingRule ( nil , newFwdRule ) ; err != nil {
2020-12-01 01:06:26 +00:00
return nil , err
}
}
2019-08-30 18:33:25 +00:00
// Delete the previous internal load balancer resources if necessary
if existingBackendService != nil {
g . clearPreviousInternalResources ( svc , loadBalancerName , existingBackendService , backendServiceName , hcName )
}
// Get the most recent forwarding rule for the address.
updatedFwdRule , err := g . GetRegionForwardingRule ( loadBalancerName , g . region )
if err != nil {
return nil , err
}
2020-08-10 17:43:49 +00:00
serviceState . InSuccess = true
if options . AllowGlobalAccess {
serviceState . EnabledGlobalAccess = true
}
// SubnetName is overridden to nil value if Alpha feature gate for custom subnet
// is not enabled. So, a non empty subnet name at this point implies that the
// feature is in use.
if options . SubnetName != "" {
serviceState . EnabledCustomSubnet = true
}
klog . V ( 6 ) . Infof ( "Internal Loadbalancer for Service %s ensured, updating its state %v in metrics cache" , nm , serviceState )
2019-08-30 18:33:25 +00:00
status := & v1 . LoadBalancerStatus { }
status . Ingress = [ ] v1 . LoadBalancerIngress { { IP : updatedFwdRule . IPAddress } }
return status , nil
}
func ( g * Cloud ) clearPreviousInternalResources ( svc * v1 . Service , loadBalancerName string , existingBackendService * compute . BackendService , expectedBSName , expectedHCName string ) {
// If a new backend service was created, delete the old one.
if existingBackendService . Name != expectedBSName {
klog . V ( 2 ) . Infof ( "clearPreviousInternalResources(%v): expected backend service %q does not match previous %q - deleting backend service" , loadBalancerName , expectedBSName , existingBackendService . Name )
if err := g . teardownInternalBackendService ( existingBackendService . Name ) ; err != nil && ! isNotFound ( err ) {
klog . Warningf ( "clearPreviousInternalResources: could not delete old backend service: %v, err: %v" , existingBackendService . Name , err )
}
}
// If a new health check was created, delete the old one.
if len ( existingBackendService . HealthChecks ) == 1 {
existingHCName := getNameFromLink ( existingBackendService . HealthChecks [ 0 ] )
if existingHCName != expectedHCName {
klog . V ( 2 ) . Infof ( "clearPreviousInternalResources(%v): expected health check %q does not match previous %q - deleting health check" , loadBalancerName , expectedHCName , existingHCName )
if err := g . teardownInternalHealthCheckAndFirewall ( svc , existingHCName ) ; err != nil {
klog . Warningf ( "clearPreviousInternalResources: could not delete existing healthcheck: %v, err: %v" , existingHCName , err )
}
}
} else if len ( existingBackendService . HealthChecks ) > 1 {
klog . Warningf ( "clearPreviousInternalResources(%v): more than one health check on the backend service %v, %v" , loadBalancerName , existingBackendService . Name , existingBackendService . HealthChecks )
}
}
// updateInternalLoadBalancer is called when the list of nodes has changed. Therefore, only the instance groups
// and possibly the backend service need to be updated.
func ( g * Cloud ) updateInternalLoadBalancer ( clusterName , clusterID string , svc * v1 . Service , nodes [ ] * v1 . Node ) error {
2019-09-27 21:51:53 +00:00
if g . AlphaFeatureGate . Enabled ( AlphaFeatureILBSubsets ) {
return cloudprovider . ImplementedElsewhere
2019-08-30 18:33:25 +00:00
}
g . sharedResourceLock . Lock ( )
defer g . sharedResourceLock . Unlock ( )
igName := makeInstanceGroupName ( clusterID )
igLinks , err := g . ensureInternalInstanceGroups ( igName , nodes )
if err != nil {
return err
}
// Generate the backend service name
2019-12-12 01:27:03 +00:00
_ , _ , protocol := getPortsAndProtocol ( svc . Spec . Ports )
2019-08-30 18:33:25 +00:00
scheme := cloud . SchemeInternal
loadBalancerName := g . GetLoadBalancerName ( context . TODO ( ) , clusterName , svc )
backendServiceName := makeBackendServiceName ( loadBalancerName , clusterID , shareBackendService ( svc ) , scheme , protocol , svc . Spec . SessionAffinity )
// Ensure the backend service has the proper backend/instance-group links
return g . ensureInternalBackendServiceGroups ( backendServiceName , igLinks )
}
func ( g * Cloud ) ensureInternalLoadBalancerDeleted ( clusterName , clusterID string , svc * v1 . Service ) error {
loadBalancerName := g . GetLoadBalancerName ( context . TODO ( ) , clusterName , svc )
2020-08-10 17:43:49 +00:00
svcNamespacedName := types . NamespacedName { Name : svc . Name , Namespace : svc . Namespace }
2019-12-12 01:27:03 +00:00
_ , _ , protocol := getPortsAndProtocol ( svc . Spec . Ports )
2019-08-30 18:33:25 +00:00
scheme := cloud . SchemeInternal
sharedBackend := shareBackendService ( svc )
sharedHealthCheck := ! servicehelpers . RequestsOnlyLocalTraffic ( svc )
g . sharedResourceLock . Lock ( )
defer g . sharedResourceLock . Unlock ( )
klog . V ( 2 ) . Infof ( "ensureInternalLoadBalancerDeleted(%v): attempting delete of region internal address" , loadBalancerName )
ensureAddressDeleted ( g , loadBalancerName , g . region )
klog . V ( 2 ) . Infof ( "ensureInternalLoadBalancerDeleted(%v): deleting region internal forwarding rule" , loadBalancerName )
if err := ignoreNotFound ( g . DeleteRegionForwardingRule ( loadBalancerName , g . region ) ) ; err != nil {
return err
}
backendServiceName := makeBackendServiceName ( loadBalancerName , clusterID , sharedBackend , scheme , protocol , svc . Spec . SessionAffinity )
klog . V ( 2 ) . Infof ( "ensureInternalLoadBalancerDeleted(%v): deleting region backend service %v" , loadBalancerName , backendServiceName )
if err := g . teardownInternalBackendService ( backendServiceName ) ; err != nil {
return err
}
2019-12-12 01:27:03 +00:00
deleteFunc := func ( fwName string ) error {
if err := ignoreNotFound ( g . DeleteFirewall ( fwName ) ) ; err != nil {
if isForbidden ( err ) && g . OnXPN ( ) {
klog . V ( 2 ) . Infof ( "ensureInternalLoadBalancerDeleted(%v): could not delete traffic firewall on XPN cluster. Raising event." , loadBalancerName )
g . raiseFirewallChangeNeededEvent ( svc , FirewallToGCloudDeleteCmd ( fwName , g . NetworkProjectID ( ) ) )
return nil
}
2019-08-30 18:33:25 +00:00
return err
}
2019-12-12 01:27:03 +00:00
return nil
}
fwName := MakeFirewallName ( loadBalancerName )
klog . V ( 2 ) . Infof ( "ensureInternalLoadBalancerDeleted(%v): deleting firewall %s for traffic" ,
loadBalancerName , fwName )
if err := deleteFunc ( fwName ) ; err != nil {
return err
}
klog . V ( 2 ) . Infof ( "ensureInternalLoadBalancerDeleted(%v): deleting legacy name firewall for traffic" , loadBalancerName )
if err := deleteFunc ( loadBalancerName ) ; err != nil {
return err
2019-08-30 18:33:25 +00:00
}
hcName := makeHealthCheckName ( loadBalancerName , clusterID , sharedHealthCheck )
klog . V ( 2 ) . Infof ( "ensureInternalLoadBalancerDeleted(%v): deleting health check %v and its firewall" , loadBalancerName , hcName )
if err := g . teardownInternalHealthCheckAndFirewall ( svc , hcName ) ; err != nil {
return err
}
// Try deleting instance groups - expect ResourceInuse error if needed by other LBs
igName := makeInstanceGroupName ( clusterID )
2020-06-23 22:12:14 +00:00
klog . V ( 2 ) . Infof ( "ensureInternalLoadBalancerDeleted(%v): Attempting delete of instanceGroup %v" , loadBalancerName , igName )
2019-08-30 18:33:25 +00:00
if err := g . ensureInternalInstanceGroupsDeleted ( igName ) ; err != nil && ! isInUsedByError ( err ) {
return err
}
2020-06-23 22:12:14 +00:00
klog . V ( 2 ) . Infof ( "ensureInternalLoadBalancerDeleted(%v): Removing %q finalizer" , loadBalancerName , ILBFinalizerV1 )
2020-03-26 21:07:15 +00:00
if err := removeFinalizer ( svc , g . client . CoreV1 ( ) , ILBFinalizerV1 ) ; err != nil {
2020-08-10 17:43:49 +00:00
klog . Errorf ( "Failed to remove finalizer '%s' on service %s - %v" , ILBFinalizerV1 , svcNamespacedName , err )
2020-03-26 21:07:15 +00:00
return err
}
2020-08-10 17:43:49 +00:00
klog . V ( 6 ) . Infof ( "Internal Loadbalancer for Service %s deleted, removing its state from metrics cache" , svcNamespacedName )
g . metricsCollector . DeleteL4ILBService ( svcNamespacedName . String ( ) )
2019-08-30 18:33:25 +00:00
return nil
}
func ( g * Cloud ) teardownInternalBackendService ( bsName string ) error {
if err := g . DeleteRegionBackendService ( bsName , g . region ) ; err != nil {
if isNotFound ( err ) {
klog . V ( 2 ) . Infof ( "teardownInternalBackendService(%v): backend service already deleted. err: %v" , bsName , err )
return nil
} else if isInUsedByError ( err ) {
klog . V ( 2 ) . Infof ( "teardownInternalBackendService(%v): backend service in use." , bsName )
return nil
} else {
return fmt . Errorf ( "failed to delete backend service: %v, err: %v" , bsName , err )
}
}
klog . V ( 2 ) . Infof ( "teardownInternalBackendService(%v): backend service deleted" , bsName )
return nil
}
func ( g * Cloud ) teardownInternalHealthCheckAndFirewall ( svc * v1 . Service , hcName string ) error {
if err := g . DeleteHealthCheck ( hcName ) ; err != nil {
if isNotFound ( err ) {
klog . V ( 2 ) . Infof ( "teardownInternalHealthCheckAndFirewall(%v): health check does not exist." , hcName )
// Purposely do not early return - double check the firewall does not exist
} else if isInUsedByError ( err ) {
klog . V ( 2 ) . Infof ( "teardownInternalHealthCheckAndFirewall(%v): health check in use." , hcName )
return nil
} else {
return fmt . Errorf ( "failed to delete health check: %v, err: %v" , hcName , err )
}
}
klog . V ( 2 ) . Infof ( "teardownInternalHealthCheckAndFirewall(%v): health check deleted" , hcName )
hcFirewallName := makeHealthCheckFirewallNameFromHC ( hcName )
if err := ignoreNotFound ( g . DeleteFirewall ( hcFirewallName ) ) ; err != nil {
if isForbidden ( err ) && g . OnXPN ( ) {
klog . V ( 2 ) . Infof ( "teardownInternalHealthCheckAndFirewall(%v): could not delete health check traffic firewall on XPN cluster. Raising Event." , hcName )
g . raiseFirewallChangeNeededEvent ( svc , FirewallToGCloudDeleteCmd ( hcFirewallName , g . NetworkProjectID ( ) ) )
return nil
}
return fmt . Errorf ( "failed to delete health check firewall: %v, err: %v" , hcFirewallName , err )
}
klog . V ( 2 ) . Infof ( "teardownInternalHealthCheckAndFirewall(%v): health check firewall deleted" , hcFirewallName )
return nil
}
2019-12-12 01:27:03 +00:00
func ( g * Cloud ) ensureInternalFirewall ( svc * v1 . Service , fwName , fwDesc string , sourceRanges [ ] string , portRanges [ ] string , protocol v1 . Protocol , nodes [ ] * v1 . Node , legacyFwName string ) error {
2019-08-30 18:33:25 +00:00
klog . V ( 2 ) . Infof ( "ensureInternalFirewall(%v): checking existing firewall" , fwName )
targetTags , err := g . GetNodeTags ( nodeNames ( nodes ) )
if err != nil {
return err
}
existingFirewall , err := g . GetFirewall ( fwName )
if err != nil && ! isNotFound ( err ) {
return err
}
2019-12-12 01:27:03 +00:00
// TODO(84821) Remove legacyFwName logic after 3 releases, so there would have been atleast 2 master upgrades that would
// have triggered service sync and deletion of the legacy rules.
if legacyFwName != "" {
// Check for firewall named with the legacy naming scheme and delete if found.
legacyFirewall , err := g . GetFirewall ( legacyFwName )
if err != nil && ! isNotFound ( err ) {
return err
}
if legacyFirewall != nil && existingFirewall != nil {
// Delete the legacyFirewall rule if the new one was already created. If not, it will be deleted in the
// next sync or when the service is deleted.
defer func ( ) {
err = g . DeleteFirewall ( legacyFwName )
if err != nil {
klog . Errorf ( "Failed to delete legacy firewall %s for service %s/%s, err %v" ,
legacyFwName , svc . Namespace , svc . Name , err )
} else {
klog . V ( 2 ) . Infof ( "Successfully deleted legacy firewall %s for service %s/%s" ,
legacyFwName , svc . Namespace , svc . Name )
}
} ( )
}
}
2019-08-30 18:33:25 +00:00
expectedFirewall := & compute . Firewall {
Name : fwName ,
Description : fwDesc ,
Network : g . networkURL ,
SourceRanges : sourceRanges ,
TargetTags : targetTags ,
Allowed : [ ] * compute . FirewallAllowed {
{
IPProtocol : strings . ToLower ( string ( protocol ) ) ,
2019-12-12 01:27:03 +00:00
Ports : portRanges ,
2019-08-30 18:33:25 +00:00
} ,
} ,
}
if existingFirewall == nil {
klog . V ( 2 ) . Infof ( "ensureInternalFirewall(%v): creating firewall" , fwName )
err = g . CreateFirewall ( expectedFirewall )
if err != nil && isForbidden ( err ) && g . OnXPN ( ) {
klog . V ( 2 ) . Infof ( "ensureInternalFirewall(%v): do not have permission to create firewall rule (on XPN). Raising event." , fwName )
g . raiseFirewallChangeNeededEvent ( svc , FirewallToGCloudCreateCmd ( expectedFirewall , g . NetworkProjectID ( ) ) )
return nil
}
return err
}
if firewallRuleEqual ( expectedFirewall , existingFirewall ) {
return nil
}
klog . V ( 2 ) . Infof ( "ensureInternalFirewall(%v): updating firewall" , fwName )
err = g . UpdateFirewall ( expectedFirewall )
if err != nil && isForbidden ( err ) && g . OnXPN ( ) {
klog . V ( 2 ) . Infof ( "ensureInternalFirewall(%v): do not have permission to update firewall rule (on XPN). Raising event." , fwName )
g . raiseFirewallChangeNeededEvent ( svc , FirewallToGCloudUpdateCmd ( expectedFirewall , g . NetworkProjectID ( ) ) )
return nil
}
return err
}
func ( g * Cloud ) ensureInternalFirewalls ( loadBalancerName , ipAddress , clusterID string , nm types . NamespacedName , svc * v1 . Service , healthCheckPort string , sharedHealthCheck bool , nodes [ ] * v1 . Node ) error {
// First firewall is for ingress traffic
fwDesc := makeFirewallDescription ( nm . String ( ) , ipAddress )
2019-12-12 01:27:03 +00:00
_ , portRanges , protocol := getPortsAndProtocol ( svc . Spec . Ports )
2019-08-30 18:33:25 +00:00
sourceRanges , err := servicehelpers . GetLoadBalancerSourceRanges ( svc )
if err != nil {
return err
}
2019-12-12 01:27:03 +00:00
err = g . ensureInternalFirewall ( svc , MakeFirewallName ( loadBalancerName ) , fwDesc , sourceRanges . StringSlice ( ) , portRanges , protocol , nodes , loadBalancerName )
2019-08-30 18:33:25 +00:00
if err != nil {
return err
}
// Second firewall is for health checking nodes / services
fwHCName := makeHealthCheckFirewallName ( loadBalancerName , clusterID , sharedHealthCheck )
2019-12-12 01:27:03 +00:00
hcSrcRanges := L4LoadBalancerSrcRanges ( )
return g . ensureInternalFirewall ( svc , fwHCName , "" , hcSrcRanges , [ ] string { healthCheckPort } , v1 . ProtocolTCP , nodes , "" )
2019-08-30 18:33:25 +00:00
}
func ( g * Cloud ) ensureInternalHealthCheck ( name string , svcName types . NamespacedName , shared bool , path string , port int32 ) ( * compute . HealthCheck , error ) {
klog . V ( 2 ) . Infof ( "ensureInternalHealthCheck(%v, %v, %v): checking existing health check" , name , path , port )
expectedHC := newInternalLBHealthCheck ( name , svcName , shared , path , port )
hc , err := g . GetHealthCheck ( name )
if err != nil && ! isNotFound ( err ) {
return nil , err
}
if hc == nil {
klog . V ( 2 ) . Infof ( "ensureInternalHealthCheck: did not find health check %v, creating one with port %v path %v" , name , port , path )
if err = g . CreateHealthCheck ( expectedHC ) ; err != nil {
return nil , err
}
hc , err = g . GetHealthCheck ( name )
if err != nil {
klog . Errorf ( "Failed to get http health check %v" , err )
return nil , err
}
klog . V ( 2 ) . Infof ( "ensureInternalHealthCheck: created health check %v" , name )
return hc , nil
}
if needToUpdateHealthChecks ( hc , expectedHC ) {
klog . V ( 2 ) . Infof ( "ensureInternalHealthCheck: health check %v exists but parameters have drifted - updating..." , name )
2019-09-27 21:51:53 +00:00
mergeHealthChecks ( hc , expectedHC )
2019-08-30 18:33:25 +00:00
if err := g . UpdateHealthCheck ( expectedHC ) ; err != nil {
klog . Warningf ( "Failed to reconcile http health check %v parameters" , name )
return nil , err
}
klog . V ( 2 ) . Infof ( "ensureInternalHealthCheck: corrected health check %v parameters successful" , name )
hc , err = g . GetHealthCheck ( name )
if err != nil {
return nil , err
}
}
return hc , nil
}
func ( g * Cloud ) ensureInternalInstanceGroup ( name , zone string , nodes [ ] * v1 . Node ) ( string , error ) {
klog . V ( 2 ) . Infof ( "ensureInternalInstanceGroup(%v, %v): checking group that it contains %v nodes" , name , zone , len ( nodes ) )
ig , err := g . GetInstanceGroup ( name , zone )
if err != nil && ! isNotFound ( err ) {
return "" , err
}
kubeNodes := sets . NewString ( )
for _ , n := range nodes {
kubeNodes . Insert ( n . Name )
}
2020-04-19 06:53:00 +00:00
// Individual InstanceGroup has a limit for 1000 instances in it.
// As a result, it's not possible to add more to it.
// Given that the long-term fix (AlphaFeatureILBSubsets) is already in-progress,
// to stop the bleeding we now simply cut down the contents to first 1000
// instances in the alphabetical order. Since there is a limitation for
// 250 backend VMs for ILB, this isn't making things worse.
if len ( kubeNodes ) > maxInstancesPerInstanceGroup {
klog . Warningf ( "Limiting number of VMs for InstanceGroup %s to %d" , name , maxInstancesPerInstanceGroup )
kubeNodes = sets . NewString ( kubeNodes . List ( ) [ : maxInstancesPerInstanceGroup ] ... )
}
2019-08-30 18:33:25 +00:00
gceNodes := sets . NewString ( )
if ig == nil {
klog . V ( 2 ) . Infof ( "ensureInternalInstanceGroup(%v, %v): creating instance group" , name , zone )
newIG := & compute . InstanceGroup { Name : name }
if err = g . CreateInstanceGroup ( newIG , zone ) ; err != nil {
return "" , err
}
ig , err = g . GetInstanceGroup ( name , zone )
if err != nil {
return "" , err
}
} else {
instances , err := g . ListInstancesInInstanceGroup ( name , zone , allInstances )
if err != nil {
return "" , err
}
for _ , ins := range instances {
parts := strings . Split ( ins . Instance , "/" )
gceNodes . Insert ( parts [ len ( parts ) - 1 ] )
}
}
removeNodes := gceNodes . Difference ( kubeNodes ) . List ( )
addNodes := kubeNodes . Difference ( gceNodes ) . List ( )
if len ( removeNodes ) != 0 {
klog . V ( 2 ) . Infof ( "ensureInternalInstanceGroup(%v, %v): removing nodes: %v" , name , zone , removeNodes )
instanceRefs := g . ToInstanceReferences ( zone , removeNodes )
// Possible we'll receive 404's here if the instance was deleted before getting to this point.
if err = g . RemoveInstancesFromInstanceGroup ( name , zone , instanceRefs ) ; err != nil && ! isNotFound ( err ) {
return "" , err
}
}
if len ( addNodes ) != 0 {
klog . V ( 2 ) . Infof ( "ensureInternalInstanceGroup(%v, %v): adding nodes: %v" , name , zone , addNodes )
instanceRefs := g . ToInstanceReferences ( zone , addNodes )
if err = g . AddInstancesToInstanceGroup ( name , zone , instanceRefs ) ; err != nil {
return "" , err
}
}
return ig . SelfLink , nil
}
// ensureInternalInstanceGroups generates an unmanaged instance group for every zone
// where a K8s node exists. It also ensures that each node belongs to an instance group
func ( g * Cloud ) ensureInternalInstanceGroups ( name string , nodes [ ] * v1 . Node ) ( [ ] string , error ) {
zonedNodes := splitNodesByZone ( nodes )
klog . V ( 2 ) . Infof ( "ensureInternalInstanceGroups(%v): %d nodes over %d zones in region %v" , name , len ( nodes ) , len ( zonedNodes ) , g . region )
var igLinks [ ] string
for zone , nodes := range zonedNodes {
igLink , err := g . ensureInternalInstanceGroup ( name , zone , nodes )
if err != nil {
return [ ] string { } , err
}
igLinks = append ( igLinks , igLink )
}
return igLinks , nil
}
func ( g * Cloud ) ensureInternalInstanceGroupsDeleted ( name string ) error {
// List of nodes isn't available here - fetch all zones in region and try deleting this cluster's ig
zones , err := g . ListZonesInRegion ( g . region )
if err != nil {
return err
}
klog . V ( 2 ) . Infof ( "ensureInternalInstanceGroupsDeleted(%v): attempting delete instance group in all %d zones" , name , len ( zones ) )
for _ , z := range zones {
if err := g . DeleteInstanceGroup ( name , z . Name ) ; err != nil && ! isNotFoundOrInUse ( err ) {
return err
}
}
return nil
}
func ( g * Cloud ) ensureInternalBackendService ( name , description string , affinityType v1 . ServiceAffinity , scheme cloud . LbScheme , protocol v1 . Protocol , igLinks [ ] string , hcLink string ) error {
klog . V ( 2 ) . Infof ( "ensureInternalBackendService(%v, %v, %v): checking existing backend service with %d groups" , name , scheme , protocol , len ( igLinks ) )
bs , err := g . GetRegionBackendService ( name , g . region )
if err != nil && ! isNotFound ( err ) {
return err
}
backends := backendsFromGroupLinks ( igLinks )
expectedBS := & compute . BackendService {
Name : name ,
Protocol : string ( protocol ) ,
Description : description ,
HealthChecks : [ ] string { hcLink } ,
Backends : backends ,
SessionAffinity : translateAffinityType ( affinityType ) ,
LoadBalancingScheme : string ( scheme ) ,
}
// Create backend service if none was found
if bs == nil {
klog . V ( 2 ) . Infof ( "ensureInternalBackendService: creating backend service %v" , name )
err := g . CreateRegionBackendService ( expectedBS , g . region )
if err != nil {
return err
}
klog . V ( 2 ) . Infof ( "ensureInternalBackendService: created backend service %v successfully" , name )
return nil
}
if backendSvcEqual ( expectedBS , bs ) {
return nil
}
klog . V ( 2 ) . Infof ( "ensureInternalBackendService: updating backend service %v" , name )
// Set fingerprint for optimistic locking
expectedBS . Fingerprint = bs . Fingerprint
if err := g . UpdateRegionBackendService ( expectedBS , g . region ) ; err != nil {
return err
}
klog . V ( 2 ) . Infof ( "ensureInternalBackendService: updated backend service %v successfully" , name )
return nil
}
// ensureInternalBackendServiceGroups updates backend services if their list of backend instance groups is incorrect.
func ( g * Cloud ) ensureInternalBackendServiceGroups ( name string , igLinks [ ] string ) error {
klog . V ( 2 ) . Infof ( "ensureInternalBackendServiceGroups(%v): checking existing backend service's groups" , name )
bs , err := g . GetRegionBackendService ( name , g . region )
if err != nil {
return err
}
backends := backendsFromGroupLinks ( igLinks )
if backendsListEqual ( bs . Backends , backends ) {
return nil
}
// Set the backend service's backends to the updated list.
bs . Backends = backends
klog . V ( 2 ) . Infof ( "ensureInternalBackendServiceGroups: updating backend service %v" , name )
if err := g . UpdateRegionBackendService ( bs , g . region ) ; err != nil {
return err
}
klog . V ( 2 ) . Infof ( "ensureInternalBackendServiceGroups: updated backend service %v successfully" , name )
return nil
}
func shareBackendService ( svc * v1 . Service ) bool {
return GetLoadBalancerAnnotationBackendShare ( svc ) && ! servicehelpers . RequestsOnlyLocalTraffic ( svc )
}
func backendsFromGroupLinks ( igLinks [ ] string ) ( backends [ ] * compute . Backend ) {
for _ , igLink := range igLinks {
backends = append ( backends , & compute . Backend {
Group : igLink ,
} )
}
return backends
}
func newInternalLBHealthCheck ( name string , svcName types . NamespacedName , shared bool , path string , port int32 ) * compute . HealthCheck {
httpSettings := compute . HTTPHealthCheck {
Port : int64 ( port ) ,
RequestPath : path ,
}
desc := ""
if ! shared {
desc = makeHealthCheckDescription ( svcName . String ( ) )
}
return & compute . HealthCheck {
Name : name ,
CheckIntervalSec : gceHcCheckIntervalSeconds ,
TimeoutSec : gceHcTimeoutSeconds ,
HealthyThreshold : gceHcHealthyThreshold ,
UnhealthyThreshold : gceHcUnhealthyThreshold ,
HttpHealthCheck : & httpSettings ,
Type : "HTTP" ,
Description : desc ,
}
}
func firewallRuleEqual ( a , b * compute . Firewall ) bool {
return a . Description == b . Description &&
len ( a . Allowed ) == 1 && len ( a . Allowed ) == len ( b . Allowed ) &&
a . Allowed [ 0 ] . IPProtocol == b . Allowed [ 0 ] . IPProtocol &&
equalStringSets ( a . Allowed [ 0 ] . Ports , b . Allowed [ 0 ] . Ports ) &&
equalStringSets ( a . SourceRanges , b . SourceRanges ) &&
equalStringSets ( a . TargetTags , b . TargetTags )
}
// mergeHealthChecks reconciles HealthCheck configures to be no smaller than
// the default values.
// E.g. old health check interval is 2s, new default is 8.
// The HC interval will be reconciled to 8 seconds.
// If the existing health check is larger than the default interval,
// the configuration will be kept.
2019-09-27 21:51:53 +00:00
func mergeHealthChecks ( hc , newHC * compute . HealthCheck ) {
2019-08-30 18:33:25 +00:00
if hc . CheckIntervalSec > newHC . CheckIntervalSec {
newHC . CheckIntervalSec = hc . CheckIntervalSec
}
if hc . TimeoutSec > newHC . TimeoutSec {
newHC . TimeoutSec = hc . TimeoutSec
}
if hc . UnhealthyThreshold > newHC . UnhealthyThreshold {
newHC . UnhealthyThreshold = hc . UnhealthyThreshold
}
if hc . HealthyThreshold > newHC . HealthyThreshold {
newHC . HealthyThreshold = hc . HealthyThreshold
}
}
// needToUpdateHealthChecks checks whether the healthcheck needs to be updated.
func needToUpdateHealthChecks ( hc , newHC * compute . HealthCheck ) bool {
2019-09-27 21:51:53 +00:00
switch {
case
hc . HttpHealthCheck == nil ,
newHC . HttpHealthCheck == nil ,
hc . HttpHealthCheck . Port != newHC . HttpHealthCheck . Port ,
hc . HttpHealthCheck . RequestPath != newHC . HttpHealthCheck . RequestPath ,
hc . Description != newHC . Description ,
hc . CheckIntervalSec < newHC . CheckIntervalSec ,
hc . TimeoutSec < newHC . TimeoutSec ,
hc . UnhealthyThreshold < newHC . UnhealthyThreshold ,
hc . HealthyThreshold < newHC . HealthyThreshold :
2019-08-30 18:33:25 +00:00
return true
}
2019-09-27 21:51:53 +00:00
return false
2019-08-30 18:33:25 +00:00
}
// backendsListEqual asserts that backend lists are equal by instance group link only
func backendsListEqual ( a , b [ ] * compute . Backend ) bool {
if len ( a ) != len ( b ) {
return false
}
if len ( a ) == 0 {
return true
}
aSet := sets . NewString ( )
for _ , v := range a {
aSet . Insert ( v . Group )
}
bSet := sets . NewString ( )
for _ , v := range b {
bSet . Insert ( v . Group )
}
return aSet . Equal ( bSet )
}
func backendSvcEqual ( a , b * compute . BackendService ) bool {
return a . Protocol == b . Protocol &&
a . Description == b . Description &&
a . SessionAffinity == b . SessionAffinity &&
a . LoadBalancingScheme == b . LoadBalancingScheme &&
equalStringSets ( a . HealthChecks , b . HealthChecks ) &&
backendsListEqual ( a . Backends , b . Backends )
}
2019-12-12 01:27:03 +00:00
func getPortsAndProtocol ( svcPorts [ ] v1 . ServicePort ) ( ports [ ] string , portRanges [ ] string , protocol v1 . Protocol ) {
2019-08-30 18:33:25 +00:00
if len ( svcPorts ) == 0 {
2019-12-12 01:27:03 +00:00
return [ ] string { } , [ ] string { } , v1 . ProtocolUDP
2019-08-30 18:33:25 +00:00
}
// GCP doesn't support multiple protocols for a single load balancer
protocol = svcPorts [ 0 ] . Protocol
2019-12-12 01:27:03 +00:00
portInts := [ ] int { }
2019-08-30 18:33:25 +00:00
for _ , p := range svcPorts {
ports = append ( ports , strconv . Itoa ( int ( p . Port ) ) )
2019-12-12 01:27:03 +00:00
portInts = append ( portInts , int ( p . Port ) )
2019-08-30 18:33:25 +00:00
}
2019-12-12 01:27:03 +00:00
return ports , getPortRanges ( portInts ) , protocol
}
func getPortRanges ( ports [ ] int ) ( ranges [ ] string ) {
if len ( ports ) < 1 {
return ranges
}
sort . Ints ( ports )
start := ports [ 0 ]
prev := ports [ 0 ]
for ix , current := range ports {
switch {
case current == prev :
// Loop over duplicates, except if the end of list is reached.
if ix == len ( ports ) - 1 {
if start == current {
ranges = append ( ranges , fmt . Sprintf ( "%d" , current ) )
} else {
ranges = append ( ranges , fmt . Sprintf ( "%d-%d" , start , current ) )
}
}
case current == prev + 1 :
// continue the streak, create the range if this is the last element in the list.
if ix == len ( ports ) - 1 {
ranges = append ( ranges , fmt . Sprintf ( "%d-%d" , start , current ) )
}
default :
// current is not prev + 1, streak is broken. Construct the range and handle last element case.
if start == prev {
ranges = append ( ranges , fmt . Sprintf ( "%d" , prev ) )
} else {
ranges = append ( ranges , fmt . Sprintf ( "%d-%d" , start , prev ) )
}
if ix == len ( ports ) - 1 {
ranges = append ( ranges , fmt . Sprintf ( "%d" , current ) )
}
// reset start element
start = current
}
prev = current
}
return ranges
2019-08-30 18:33:25 +00:00
}
func ( g * Cloud ) getBackendServiceLink ( name string ) string {
return g . service . BasePath + strings . Join ( [ ] string { g . projectID , "regions" , g . region , "backendServices" , name } , "/" )
}
func getNameFromLink ( link string ) string {
if link == "" {
return ""
}
fields := strings . Split ( link , "/" )
return fields [ len ( fields ) - 1 ]
}
2019-12-12 01:27:03 +00:00
// ilbIPToUse determines which IP address needs to be used in the ForwardingRule. If an IP has been
// specified by the user, that is used. If there is an existing ForwardingRule, the ip address from
// that is reused. In case a subnetwork change is requested, the existing ForwardingRule IP is ignored.
func ilbIPToUse ( svc * v1 . Service , fwdRule * compute . ForwardingRule , requestedSubnet string ) string {
2019-08-30 18:33:25 +00:00
if svc . Spec . LoadBalancerIP != "" {
return svc . Spec . LoadBalancerIP
}
2019-12-12 01:27:03 +00:00
if fwdRule == nil {
return ""
2019-08-30 18:33:25 +00:00
}
2019-12-12 01:27:03 +00:00
if requestedSubnet != fwdRule . Subnetwork {
// reset ip address since subnet is being changed.
return ""
}
return fwdRule . IPAddress
2019-08-30 18:33:25 +00:00
}
2019-09-27 21:51:53 +00:00
func getILBOptions ( svc * v1 . Service ) ILBOptions {
2019-12-12 01:27:03 +00:00
return ILBOptions { AllowGlobalAccess : GetLoadBalancerAnnotationAllowGlobalAccess ( svc ) ,
SubnetName : GetLoadBalancerAnnotationSubnet ( svc ) ,
}
2019-09-27 21:51:53 +00:00
}
type forwardingRuleDescription struct {
ServiceName string ` json:"kubernetes.io/service-name" `
APIVersion meta . Version ` json:"kubernetes.io/api-version,omitempty" `
}
// marshal the description as a JSON-encoded string.
func ( d * forwardingRuleDescription ) marshal ( ) ( string , error ) {
out , err := json . Marshal ( d )
if err != nil {
return "" , err
}
return string ( out ) , err
}
// unmarshal desc JSON-encoded string into this structure.
func ( d * forwardingRuleDescription ) unmarshal ( desc string ) error {
return json . Unmarshal ( [ ] byte ( desc ) , d )
}
func getFwdRuleAPIVersion ( rule * compute . ForwardingRule ) ( meta . Version , error ) {
d := & forwardingRuleDescription { }
if rule . Description == "" {
return meta . VersionGA , nil
}
if err := d . unmarshal ( rule . Description ) ; err != nil {
return meta . VersionGA , fmt . Errorf ( "Failed to get APIVersion from Forwarding rule %s - %v" , rule . Name , err )
}
if d . APIVersion == "" {
d . APIVersion = meta . VersionGA
}
return d . APIVersion , nil
}
2020-08-10 17:43:49 +00:00
func ( g * Cloud ) ensureInternalForwardingRule ( existingFwdRule , newFwdRule * compute . ForwardingRule ) ( err error ) {
2019-09-27 21:51:53 +00:00
if existingFwdRule != nil {
2020-08-10 17:43:49 +00:00
if forwardingRulesEqual ( existingFwdRule , newFwdRule ) {
klog . V ( 4 ) . Infof ( "existingFwdRule == newFwdRule, no updates needed (existingFwdRule == %+v)" , existingFwdRule )
2019-09-27 21:51:53 +00:00
return nil
}
klog . V ( 2 ) . Infof ( "ensureInternalLoadBalancer(%v): deleting existing forwarding rule with IP address %v" , existingFwdRule . Name , existingFwdRule . IPAddress )
if err = ignoreNotFound ( g . DeleteRegionForwardingRule ( existingFwdRule . Name , g . region ) ) ; err != nil {
return err
}
}
// At this point, the existing rule has been deleted if required.
// Create the rule based on the api version determined
2020-08-10 17:43:49 +00:00
klog . V ( 2 ) . Infof ( "ensureInternalLoadBalancer(%v): creating forwarding rule" , newFwdRule . Name )
if err = g . CreateRegionForwardingRule ( newFwdRule , g . region ) ; err != nil {
return err
2019-09-27 21:51:53 +00:00
}
2020-08-10 17:43:49 +00:00
klog . V ( 2 ) . Infof ( "ensureInternalLoadBalancer(%v): created forwarding rule" , newFwdRule . Name )
return nil
}
func forwardingRulesEqual ( old , new * compute . ForwardingRule ) bool {
2021-02-22 20:08:19 +00:00
// basepath could have differences like compute.googleapis.com vs www.googleapis.com, compare resourceIDs
oldResourceID , err := cloud . ParseResourceURL ( old . BackendService )
if err != nil {
klog . Errorf ( "forwardingRulesEqual(): failed to parse backend resource URL from existing FR, err - %v" , err )
}
newResourceID , err := cloud . ParseResourceURL ( new . BackendService )
if err != nil {
klog . Errorf ( "forwardingRulesEqual(): failed to parse resource URL from new FR, err - %v" , err )
}
2020-08-10 17:43:49 +00:00
return ( old . IPAddress == "" || new . IPAddress == "" || old . IPAddress == new . IPAddress ) &&
old . IPProtocol == new . IPProtocol &&
old . LoadBalancingScheme == new . LoadBalancingScheme &&
equalStringSets ( old . Ports , new . Ports ) &&
2021-02-22 20:08:19 +00:00
oldResourceID . Equal ( newResourceID ) &&
2020-08-10 17:43:49 +00:00
old . AllowGlobalAccess == new . AllowGlobalAccess &&
old . Subnetwork == new . Subnetwork
2019-09-27 21:51:53 +00:00
}