From 03bb1b9770457ccb66f95102095be6b9520bdede Mon Sep 17 00:00:00 2001 From: Erik Sundell Date: Wed, 6 May 2020 09:53:29 +0200 Subject: [PATCH 1/2] coredns: readiness- and livenessProbe tweaks The readinessProbe was delaying the startup of coredns greatly. This change brings startup times from ~15s to ~2-3s when testing locally. A reduction of ~80%. The livenessProbe would also take potentially more than a minute to be declared unhealthy and restarted which is now tweaked down to about 30 seconds For more information about the probes, see: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#configure-probes --- manifests/coredns.yaml | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/manifests/coredns.yaml b/manifests/coredns.yaml index f53b65807c..66305ea049 100644 --- a/manifests/coredns.yaml +++ b/manifests/coredns.yaml @@ -143,18 +143,20 @@ spec: port: 8080 scheme: HTTP initialDelaySeconds: 60 - timeoutSeconds: 5 + periodSeconds: 10 + timeoutSeconds: 1 successThreshold: 1 - failureThreshold: 5 + failureThreshold: 3 readinessProbe: httpGet: path: /ready port: 8181 scheme: HTTP - initialDelaySeconds: 10 - timeoutSeconds: 5 + initialDelaySeconds: 0 + periodSeconds: 2 + timeoutSeconds: 1 successThreshold: 1 - failureThreshold: 5 + failureThreshold: 3 dnsPolicy: Default volumes: - name: config-volume From 27ae2fb9c863545403477224d22319957eb95bff Mon Sep 17 00:00:00 2001 From: Erik Sundell Date: Thu, 7 May 2020 15:40:12 +0200 Subject: [PATCH 2/2] coredns: go generate --- pkg/deploy/zz_generated_bindata.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/deploy/zz_generated_bindata.go b/pkg/deploy/zz_generated_bindata.go index da61703685..7d115bd117 100644 --- a/pkg/deploy/zz_generated_bindata.go +++ b/pkg/deploy/zz_generated_bindata.go @@ -108,7 +108,7 @@ func ccmYaml() (*asset, error) { return a, nil } -var _corednsYaml = []byte("\x1f\x8b\x08\x00\x00\x00\x00\x00\x00\xff\xb4\x57\x5f\x6f\x1b\x39\x0e\x7f\xf7\xa7\x10\xe6\xd0\xb7\x1b\x27\x46\x90\x5e\x4e\x6f\x6d\x9c\x6b\x03\x34\xae\x11\x27\x7d\x39\x2c\x0a\x5a\x43\x7b\xb4\xd1\x88\x5a\x49\xe3\xc6\xdb\xcd\x77\x5f\x68\xfe\x45\x72\x26\x45\x1a\x74\xe7\xc5\x92\x28\xfe\x28\x52\xe4\x4f\x34\x18\xf9\x05\xad\x93\xa4\x39\xdb\xcd\x26\x77\x52\x17\x9c\xad\xd0\xee\xa4\xc0\x77\x42\x50\xad\xfd\xa4\x42\x0f\x05\x78\xe0\x13\xc6\x34\x54\xc8\x99\x20\x8b\x85\x76\xdd\xdc\x19\x10\xc8\xd9\x5d\xbd\xc6\xdc\xed\x9d\xc7\x6a\x92\xe7\xf9\x24\x86\xb6\x6b\x10\x53\xa8\x7d\x49\x56\xfe\x09\x5e\x92\x9e\xde\x9d\xb9\xa9\xa4\xa3\xdd\x6c\x8d\x1e\x7a\xcb\xe7\xaa\x76\x1e\xed\x35\x29\x4c\xcc\x2a\x58\xa3\x72\x61\xc4\x1a\x3b\x56\xa3\xc7\x46\x7f\x4d\xe4\x9d\xb7\x60\x8c\xd4\xdb\xd6\x50\x5e\xe0\x06\x6a\xe5\xdd\x70\xde\xf6\x54\xbc\x3f\xb6\xad\x15\x3a\x3e\xc9\x19\x18\xf9\xc1\x52\x6d\x1a\xe4\x9c\x65\xd9\x84\x31\x8b\x8e\x6a\x2b\xb0\x5b\x43\x5d\x18\x92\xba\x01\xcb\x99\x6b\x23\xd3\x4e\x0c\x15\xed\x60\x08\x42\x98\xee\xd0\xae\x3b\x5d\x25\x9d\x6f\x06\xdf\xc0\x8b\xf2\x65\xf6\x34\x15\x87\x30\x5b\xf4\xbf\x22\xa0\xef\xa5\x2e\xa4\xde\x26\x71\x05\xad\xc9\x37\xea\x5d\x70\xc7\x70\x93\x78\x43\xed\xa9\x36\x05\x78\xe4\x2c\xf3\xb6\xc6\xec\xd7\x5f\x0f\x29\xbc\xc6\x4d\x73\xbe\x2e\x60\x3f\x70\x78\xc2\xd8\xd3\xdc\x79\x06\xd9\xd5\xeb\xdf\x51\xf8\xe6\xee\x47\x53\xfd\xd5\x09\x3e\xd4\xce\x39\xe9\x8d\xdc\x5e\x81\x79\x4d\xd9\xf4\xdb\xcf\xc9\xe2\x46\x2a\xe4\xec\xaf\x26\xa6\x53\x7e\x7a\xc2\xbe\x37\xc3\xf0\xa1\xb5\x64\xdd\x30\x2d\x11\x94\x2f\x87\xa9\x45\x28\xf6\xc3\xec\xf1\x3a\xd8\x9b\xef\xe7\x9f\x6e\x57\x37\x17\xd7\x5f\xe7\x9f\xaf\xde\x5d\x2e\x1e\xde\x30\xa9\x73\x28\x0a\x3b\x05\x6b\x80\x49\xf3\xb6\x1d\x3c\x5a\x62\x4d\x92\x33\xa9\x1d\x8a\xda\x62\xb4\x5e\x1b\xe7\x2d\x42\x15\x2d\x6d\x40\x29\x5f\x5a\xaa\xb7\xe5\x38\xf0\xb0\xf7\xe1\xf1\xec\xe4\xbc\x63\x47\xe8\xc5\x51\x17\x9d\xa3\x05\x15\xf8\xb1\x59\x8e\xcf\x61\x51\x11\x14\x6c\xe6\xc6\x0d\x8e\x40\x1b\x4b\x15\xfa\x12\x6b\xc7\xf8\x7f\x67\xa7\x27\x83\x60\x43\xf6\x1b\xd8\x82\x4d\x5b\xbb\xa1\x00\xd5\x6e\x2a\x48\x6f\x86\x2d\x02\x44\x89\xec\xe4\x78\x58\x50\x44\x66\x92\x9e\x25\x92\x41\xb1\x06\x05\x5a\xb4\x01\x7a\x78\x92\x1d\x60\x8c\x3b\x1a\x52\x64\x8e\x46\xd1\xbe\xc2\xd7\x51\xeb\x41\xb5\x9d\xb9\x1c\x8c\xe9\xb6\xb4\x8a\x87\x35\xd8\x02\x67\x21\xa9\xe6\x8b\x55\x36\x71\x06\x45\xd0\xfe\x97\x45\xa3\xa4\x00\xc7\xd9\x6c\xc2\x58\x28\x53\x8f\xdb\x7d\x0b\xec\xf7\x06\x39\xbb\x26\xa5\xa4\xde\xde\x36\x05\xdf\x12\x44\xbc\xc2\xbb\x18\x54\x70\x7f\xab\x61\x07\x52\xc1\x3a\x64\x6d\x03\x87\x0a\x85\x27\xdb\xee\xa9\x02\x03\x7e\x8a\x0e\x3e\x7e\x74\x8f\x95\x51\x03\x70\x1c\x9d\x26\xd0\x89\xfe\x73\xce\xf7\xee\x35\xe3\xa4\xbc\x17\x07\x11\x6e\xfc\x24\x85\x36\x66\xc0\xf0\xe5\xec\x0e\xf7\x21\x64\x56\x7a\x29\x40\xbd\x2b\x0a\xd2\xee\xb3\x56\xfb\x2c\x4a\x3f\x32\x41\x93\x2c\x67\xd9\xc5\xbd\x74\xde\x65\x4f\x00\x02\x9b\xe7\x81\xcf\x0e\x58\xb4\x82\x40\x55\x2f\x04\x63\x0c\x37\x1b\x14\x9e\xb3\x6c\x41\x2b\x51\x62\x51\x2b\xec\xc5\xc1\xc2\x2a\x09\x75\xf8\xc2\x13\x70\x60\x92\x1c\x67\x4a\xea\xfa\xbe\xdb\x24\x48\x7b\x90\x1a\xed\xe0\x77\xfe\x24\x05\xdb\x4f\x56\xb0\x45\xce\x2c\x68\x51\xa2\xed\xeb\x34\xef\x7e\xf9\x6c\xfa\x76\x7a\x92\x6e\x5e\xd6\x4a\x2d\x49\x49\xb1\xe7\xec\x72\xb3\x20\xbf\xb4\xe8\xb0\xe1\xd7\xbe\x82\xa2\x47\x6f\xa8\x23\x59\x49\x9f\xac\x84\x14\xa8\xc8\xee\x39\x9b\xfd\xe7\xf8\x4a\x26\x74\xf0\x47\x8d\xee\x70\xb7\x30\x35\x67\xb3\xe3\xe3\x6a\x14\x23\x81\x00\xbb\x75\x9c\xfd\x9f\x65\x79\x28\xfc\xec\xdf\x2c\x4b\x48\xa8\x67\xe0\x8c\xfd\x36\xa8\xec\x48\xd5\x15\x5e\x85\x4c\x4a\x72\xa5\x8f\x5a\x20\xfe\xbc\xdd\x14\xd9\xaf\xc2\xfe\x25\xf8\x92\x27\x34\x97\xf8\x02\x45\xc8\x2d\xce\xc2\x7b\xfa\xc8\x5f\x64\x53\x3b\xc3\x8d\x2d\xc9\x7a\xce\x22\x46\xeb\xc9\x23\xc5\x35\x96\x3c\x09\x52\x9c\xdd\xce\x97\x3f\x8b\x93\x7b\x61\x46\xb1\x6e\xce\x7f\x80\x95\xf0\x6c\x8f\x56\xa1\xb7\x52\x8c\x9f\x2c\x46\x6b\xde\x18\xe9\xf7\xe7\xa4\x3d\xde\xfb\xf8\x6a\x41\x29\xfa\xb6\xb4\x72\x27\x15\x6e\xf1\xc2\x09\x50\x4d\xcd\xf2\xf0\x06\xb8\x38\xdc\x02\x0c\xac\xa5\x92\x5e\xe2\x41\x72\x40\x51\xa4\x0b\x39\x5b\x5c\xdc\x7c\x7d\x7f\xb9\x98\x7f\x5d\x5d\x5c\x7f\xb9\x3c\xbf\x48\xc4\x85\x25\x73\xa8\x00\x4a\x8d\x5c\xdc\x35\x91\xff\x9f\x54\xd8\x75\x1b\xe9\x35\x2a\xb9\x43\x8d\xce\x2d\x2d\xad\x31\xc6\x2b\xbd\x37\x1f\xd0\xa7\x26\x4c\x9b\x28\x07\x4f\x3a\xeb\xd2\x81\xb3\xb3\xe3\xb3\xe3\x64\xd9\x89\x12\x43\x90\x3f\xde\xdc\x2c\x23\x81\xd4\xd2\x4b\x50\x73\x54\xb0\x5f\xa1\x20\x5d\x38\xce\xde\xc6\xaa\x5e\x56\x48\xb5\x1f\x84\xa7\x91\xcc\xd5\x42\xa0\x73\x37\xa5\x45\x57\x92\x2a\x5a\x46\xef\xbf\x0d\x48\x55\x5b\x8c\xa4\xa7\x49\xf3\x21\x7f\xda\xdd\xb4\x65\x89\xbc\x9d\x9d\xcd\x5e\xed\xed\xec\x9f\xf6\xb6\xd0\xae\x27\xb9\x79\xdb\xd2\x76\x82\x96\x03\x7e\x82\x23\x44\xdf\x34\xa6\xd1\x19\xa7\xe3\xc6\x61\x8f\x95\x3b\x4c\xce\xe6\xc9\xe9\x89\x2b\x91\xf5\x81\x1e\x15\x76\x8a\x43\xdb\x35\xaa\xf9\x28\x7d\xb6\xf3\xed\x5a\xe9\x91\x9e\x26\x7a\x9e\x9f\x6d\x6a\x9e\xfc\x13\x79\x6c\xdf\xc2\xeb\xd5\xe6\x43\x16\xf8\x25\x1b\x11\x3b\x61\xc1\x3c\xfb\x8f\xe4\x05\x3d\x92\x68\xff\x3c\xe4\x5d\xc3\x10\x21\xbd\xb4\x9b\x4a\xfb\x9d\x31\x9b\x9d\x8d\xcb\x25\x8f\x5b\xf1\xc5\xea\xe1\xcd\x24\x62\xfb\xfc\x80\xcb\x4d\x4c\xd2\x87\x94\x9e\x8f\x10\xf6\x33\x0a\x2d\xd3\xe6\x23\x9c\x6c\x52\xea\x4e\x55\xfe\x0e\x00\x00\xff\xff\xba\xc2\xc2\x90\x21\x10\x00\x00") +var _corednsYaml = []byte("\x1f\x8b\x08\x00\x00\x00\x00\x00\x00\xff\xb4\x57\x5d\x6f\xdb\xb8\x12\x7d\xf7\xaf\x20\x74\xd1\xb7\x2b\x27\xbe\x41\x7b\xb3\x7c\x6b\x93\x6c\x1b\xa0\x71\x8d\x38\xe9\xcb\x62\x51\x8c\xa9\xb1\xc5\x0d\xc5\xe1\x92\x94\x1b\x6f\x37\xff\x7d\x41\x7d\x99\x74\x94\x22\x0d\xba\x7a\xb1\xc4\xe1\x9c\x21\x0f\x67\x0e\xc7\x60\xe4\x67\xb4\x4e\x92\xe6\x6c\x3b\x9b\xdc\x49\x5d\x70\xb6\x44\xbb\x95\x02\xdf\x0a\x41\xb5\xf6\x93\x0a\x3d\x14\xe0\x81\x4f\x18\xd3\x50\x21\x67\x82\x2c\x16\xda\x75\xdf\xce\x80\x40\xce\xee\xea\x15\xe6\x6e\xe7\x3c\x56\x93\x3c\xcf\x27\x31\xb4\x5d\x81\x98\x42\xed\x4b\xb2\xf2\x2f\xf0\x92\xf4\xf4\xee\xd4\x4d\x25\x1d\x6d\x67\x2b\xf4\xd0\x47\x3e\x53\xb5\xf3\x68\xaf\x49\x61\x12\x56\xc1\x0a\x95\x0b\x6f\xac\x89\x63\x35\x7a\x6c\xfc\x57\x44\xde\x79\x0b\xc6\x48\xbd\x69\x03\xe5\x05\xae\xa1\x56\xde\x0d\xeb\x6d\x57\xc5\xfb\x65\xdb\x5a\xa1\xe3\x93\x9c\x81\x91\xef\x2d\xd5\xa6\x41\xce\x59\x96\x4d\x18\xb3\xe8\xa8\xb6\x02\xbb\x31\xd4\x85\x21\xa9\x1b\xb0\x9c\xb9\x96\x99\xf6\xc3\x50\xd1\xbe\x0c\x24\x84\xcf\x2d\xda\x55\xe7\xab\xa4\xf3\xcd\xcb\x57\xf0\xa2\x7c\x5e\x3c\x4d\xc5\x21\xcc\x06\xfd\xcf\x20\xf4\x9d\xd4\x85\xd4\x9b\x84\x57\xd0\x9a\x7c\xe3\xde\x91\x3b\x86\x9b\xf0\x0d\xb5\xa7\xda\x14\xe0\x91\xb3\xcc\xdb\x1a\xb3\x9f\x7f\x3c\xa4\xf0\x1a\xd7\xcd\xfa\x3a\xc2\xbe\xb3\xe1\x09\x63\x8f\x73\xe7\x09\x64\x57\xaf\xfe\x40\xe1\x9b\xb3\x1f\x4d\xf5\x17\x27\xf8\x50\x3b\x67\xa4\xd7\x72\x73\x05\xe6\x25\x65\xd3\x4f\x3f\x23\x8b\x6b\xa9\x90\xb3\xbf\x1b\x4e\xa7\xfc\xf5\x09\xfb\xd6\xbc\x86\x07\xad\x25\xeb\x86\xcf\x12\x41\xf9\x72\xf8\xb4\x08\xc5\x6e\xf8\xda\x1f\x07\x7b\xf5\xed\xec\xe3\xed\xf2\xe6\xe2\xfa\xcb\xf9\xa7\xab\xb7\x97\xf3\x87\x57\x4c\xea\x1c\x8a\xc2\x4e\xc1\x1a\x60\xd2\xbc\x69\x5f\xf6\x91\x58\x93\xe4\x4c\x6a\x87\xa2\xb6\x18\x8d\xd7\xc6\x79\x8b\x50\x45\x43\x6b\x50\xca\x97\x96\xea\x4d\x39\x0e\x3c\xcc\x7d\xd8\xaf\x9d\x9c\x77\xec\x08\xbd\x38\xea\xd8\x39\x9a\x53\x81\x1f\x9a\xe1\x78\x1d\x16\x15\x41\xc1\x66\x6e\x3c\xe0\x08\xb4\xb1\x54\xa1\x2f\xb1\x76\x8c\xff\x32\x7b\x7d\x32\x18\xd6\x64\xbf\x82\x2d\xd8\xb4\x8d\x1b\x0a\x50\x6d\xa7\x82\xf4\x7a\x98\x22\x40\x94\xc8\x4e\x8e\x87\x01\x45\x64\x26\xe9\x5a\x22\x1b\x14\x2b\x50\xa0\x45\x4b\xd0\xc3\xa3\xec\x00\x63\xdc\xd1\x90\x22\xe7\x68\x14\xed\x2a\x7c\x99\xb4\x1e\x54\xdb\xa9\xcb\xc1\x98\x6e\x4a\xeb\x78\x58\x83\x2d\x70\x16\x92\xea\x7c\xbe\xcc\x26\xce\xa0\x08\xde\xff\xb1\x68\x94\x14\xe0\x38\x9b\x4d\x18\x0b\x65\xea\x71\xb3\x6b\x81\xfd\xce\x20\x67\xd7\xa4\x94\xd4\x9b\xdb\xa6\xe0\x5b\x81\x88\x47\x78\xc7\x41\x05\xf7\xb7\x1a\xb6\x20\x15\xac\x42\xd6\x36\x70\xa8\x50\x78\xb2\xed\x9c\x2a\x28\xe0\xc7\x68\xe1\xe3\x4b\xf7\x58\x19\x35\x00\xc7\xec\x34\x44\x27\xfe\x4f\x6d\xbe\xdf\x5e\xf3\x9e\x94\xf7\xfc\x80\xe1\x66\x9f\xa4\xd0\xc6\x0a\x18\x9e\x9c\xdd\xe1\x2e\x50\x66\xa5\x97\x02\xd4\xdb\xa2\x20\xed\x3e\x69\xb5\xcb\xa2\xf4\x23\x13\x3c\xc9\x72\x96\x5d\xdc\x4b\xe7\x5d\xf6\x08\x20\xa8\x79\x1e\xf4\xec\x40\x45\x2b\x08\x52\xf5\x4c\x30\xc6\x70\xbd\x46\xe1\x39\xcb\xe6\xb4\x14\x25\x16\xb5\xc2\xde\x1c\x22\x2c\x13\xaa\xc3\x13\xae\x80\x83\x90\xe4\x38\x53\x52\xd7\xf7\xdd\x24\x41\xda\x83\xd4\x68\x87\x7d\xe7\x8f\x52\xb0\x7d\x64\x05\x1b\xe4\xcc\x82\x16\x25\xda\xbe\x4e\xf3\xee\x97\xcf\xa6\x6f\xa6\x27\xe9\xe4\x45\xad\xd4\x82\x94\x14\x3b\xce\x2e\xd7\x73\xf2\x0b\x8b\x0e\x1b\x7d\xed\x2b\x28\xba\xf4\x86\x3a\x92\x95\xf4\xc9\x48\x48\x81\x8a\xec\x8e\xb3\xd9\xff\x8f\xaf\x64\x22\x07\x7f\xd6\xe8\x0e\x67\x0b\x53\x73\x36\x3b\x3e\xae\x46\x31\x12\x08\xb0\x1b\xc7\xd9\x6f\x2c\xcb\x43\xe1\x67\xff\x65\x59\x22\x42\xbd\x02\x67\xec\xf7\xc1\x65\x4b\xaa\xae\xf0\x2a\x64\x52\x92\x2b\x3d\x6b\x41\xf8\xf3\x76\x52\x14\xbf\x0a\xf3\x17\xe0\x4b\x9e\xc8\x5c\xb2\x17\x28\x42\x6e\x71\x16\xee\xd3\xbd\x7e\x91\x4d\xe3\x0c\x27\xb6\x20\xeb\x39\x8b\x14\xad\x17\x8f\x14\xd7\x58\xf2\x24\x48\x71\x76\x7b\xbe\xf8\x51\x9c\xdc\x0b\x33\x8a\x75\x73\xf6\x1d\xac\x44\x67\x7b\xb4\x0a\xbd\x95\x62\x7c\x65\x31\x5a\x73\xc7\x48\xbf\x3b\x23\xed\xf1\xde\xc7\x47\x0b\x4a\xd1\xd7\x85\x95\x5b\xa9\x70\x83\x17\x4e\x80\x6a\x6a\x96\x87\x3b\xc0\xc5\x74\x0b\x30\xb0\x92\x4a\x7a\x89\x07\xc9\x01\x45\x91\x0e\xe4\x6c\x7e\x71\xf3\xe5\xdd\xe5\xfc\xfc\xcb\xf2\xe2\xfa\xf3\xe5\xd9\x45\x62\x2e\x2c\x99\x43\x07\x50\x6a\xe4\xe0\xae\x89\xfc\xaf\x52\x61\xd7\x6d\xa4\xc7\xa8\xe4\x16\x35\x3a\xb7\xb0\xb4\xc2\x18\xaf\xf4\xde\xbc\x47\x9f\x86\x30\x6d\xa2\x1c\x5c\xe9\xac\x4b\x07\xce\x4e\x8f\x4f\x8f\x93\x61\x27\x4a\x0c\x24\x7f\xb8\xb9\x59\x44\x06\xa9\xa5\x97\xa0\xce\x51\xc1\x6e\x89\x82\x74\xe1\x38\x7b\x13\xbb\x1a\xb4\x92\x8a\xc1\x36\x8b\x6d\x5e\x56\x48\xb5\xdf\x1b\x23\x9b\xab\x85\x40\xe7\x6e\x4a\x8b\xae\x24\x55\xa4\xd6\x35\x48\x55\x5b\x8c\xac\x27\x49\x63\x22\x7f\x98\x8a\xb4\x9d\x89\x98\x98\x9d\xce\x5e\xcc\xc4\x77\x88\xf8\xdf\xbf\xcc\x43\xa1\x5d\x2f\x8d\xe7\x6d\x23\xdc\x19\x5a\xe5\xf8\x01\x65\x11\x7d\xab\x99\xf2\x36\x2e\xe2\x0d\x15\x1e\x2b\x77\x98\xd2\xcd\x45\xd5\xcb\x5d\x62\xeb\x8f\x60\xd4\xd8\x39\x0e\xcd\xda\xa8\xe7\xde\xfa\x64\xbf\xdc\x35\xe0\x23\x9d\x50\x74\xa9\x3f\xd9\x0a\x3d\xfa\xff\xb2\x6f\xfa\xc2\x9d\xd7\x66\x4a\x16\x54\x29\x1b\x31\x3b\x61\xc1\x3c\xf9\x3f\xe6\x19\x9d\x95\x68\xff\x72\xe4\x5d\x9b\x11\x21\x3d\xb7\x07\x4b\xbb\xa4\xb1\x98\x5d\x8c\xcb\x05\x8f\x1b\xf8\xf9\xf2\xe1\xd5\x24\xba\x23\xf2\x83\x1b\xc0\xc4\xd2\x7e\x78\x11\xe4\x23\x32\xff\x84\x43\xab\xcf\xf9\x88\x92\x9b\x54\xf0\x53\x97\x7f\x02\x00\x00\xff\xff\xc5\x25\x93\xce\x57\x10\x00\x00") func corednsYamlBytes() ([]byte, error) { return bindataRead(